Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3436)

Unified Diff: chrome/browser/plugin_installer.cc

Issue 4130012: Move URLs out of *.pak files and put them into code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove the Show call Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugin_installer.cc
diff --git a/chrome/browser/plugin_installer.cc b/chrome/browser/plugin_installer.cc
index 1b1d0c504a99c9936fd72669cc46435061db5dd5..b6ceb3cad7638b8b765717c8a83f90a1cb0688ac 100644
--- a/chrome/browser/plugin_installer.cc
+++ b/chrome/browser/plugin_installer.cc
@@ -14,6 +14,10 @@
#include "grit/theme_resources.h"
#include "webkit/glue/plugins/default_plugin_shared.h"
+// The URL for the "Problems installing" page for the Plugins infobar.
+static const char kLearnMorePluginInstallerUrl[] =
+ "http://www.google.com/support/chrome/bin/answer.py?answer=95697&topic=14687";
+
PluginInstaller::PluginInstaller(TabContents* tab_contents)
: ConfirmInfoBarDelegate(tab_contents),
tab_contents_(tab_contents) {
@@ -73,8 +77,7 @@ string16 PluginInstaller::GetLinkText() {
bool PluginInstaller::LinkClicked(WindowOpenDisposition disposition) {
// Ignore the click dispostion and always open in a new top level tab.
- tab_contents_->OpenURL(
- GURL(l10n_util::GetStringUTF8(IDS_LEARN_MORE_PLUGININSTALLER_URL)),
- GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
+ tab_contents_->OpenURL(GURL(kLearnMorePluginInstallerUrl), GURL(),
+ NEW_FOREGROUND_TAB, PageTransition::LINK);
return false; // Do not dismiss the info bar.
}

Powered by Google App Engine
This is Rietveld 408576698