Move URLs out of *.pak files and put them into code.

chrome/browser/views/clear_server_data.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/clear_server_data.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
 #include "base/string16.h"
@@ skipping 232 matching lines @@
 }
 
 void ClearServerDataView::LinkActivated(views::Link* source,
                                           int event_flags) {
   Browser* browser = Browser::Create(profile_);
   if (source == flash_link_) {
     browser->OpenURL(GURL(l10n_util::GetStringUTF8(IDS_FLASH_STORAGE_URL)),
                      GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
     browser->window()->Show();
   } else {
-    browser->OpenURL(GURL(l10n_util::GetStringUTF8(IDS_PRIVACY_DASHBOARD_URL)),
-                     GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
-    browser->window()->Show();
+    browser->OpenPrivacyDashboardTabAndActivate();

[tfarina, 2010/11/02 02:30:05]

Removed the call to Show. OK to commit?

[tony, 2010/11/02 18:40:28]

I can't even seem to find where this view is shown.  Seems fine w/o it.

It would be great if you could investigate whether we should be using Activate()
for the flash storage link too.  Maybe it should also be moved into a function
in browser.h/cc (or a more generic method that takes a URL to open and
activate).

   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ClearServerDataView, ConfirmMessageBoxObserver implementation:
 
 void ClearServerDataView::OnConfirmMessageAccept() {
   clear_data_parent_window_->StartClearingServerData();
   sync_service_->ClearServerData();
   UpdateControlEnabledState();
@@ skipping 71 matching lines @@
 }
 
 void ClearServerDataView::UpdateClearButtonEnabledState(
     bool delete_in_progress) {
   this->clear_server_data_button_->SetEnabled(
       sync_service_ != NULL &&
       sync_service_->HasSyncSetupCompleted() &&
       !delete_in_progress && allow_clear_);
 }