Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: chrome/browser/plugin_installer.cc

Issue 4130012: Move URLs out of *.pak files and put them into code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove the Show call Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/plugin_installer.h" 5 #include "chrome/browser/plugin_installer.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "chrome/browser/renderer_host/render_view_host.h" 10 #include "chrome/browser/renderer_host/render_view_host.h"
11 #include "chrome/browser/tab_contents/tab_contents.h" 11 #include "chrome/browser/tab_contents/tab_contents.h"
12 #include "grit/generated_resources.h" 12 #include "grit/generated_resources.h"
13 #include "grit/locale_settings.h" 13 #include "grit/locale_settings.h"
14 #include "grit/theme_resources.h" 14 #include "grit/theme_resources.h"
15 #include "webkit/glue/plugins/default_plugin_shared.h" 15 #include "webkit/glue/plugins/default_plugin_shared.h"
16 16
17 // The URL for the "Problems installing" page for the Plugins infobar.
18 static const char kLearnMorePluginInstallerUrl[] =
19 "http://www.google.com/support/chrome/bin/answer.py?answer=95697&topic=1 4687";
20
17 PluginInstaller::PluginInstaller(TabContents* tab_contents) 21 PluginInstaller::PluginInstaller(TabContents* tab_contents)
18 : ConfirmInfoBarDelegate(tab_contents), 22 : ConfirmInfoBarDelegate(tab_contents),
19 tab_contents_(tab_contents) { 23 tab_contents_(tab_contents) {
20 } 24 }
21 25
22 PluginInstaller::~PluginInstaller() { 26 PluginInstaller::~PluginInstaller() {
23 // Remove any InfoBars we may be showing. 27 // Remove any InfoBars we may be showing.
24 tab_contents_->RemoveInfoBar(this); 28 tab_contents_->RemoveInfoBar(this);
25 } 29 }
26 30
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 tab_contents_->render_view_host()->InstallMissingPlugin(); 70 tab_contents_->render_view_host()->InstallMissingPlugin();
67 return true; 71 return true;
68 } 72 }
69 73
70 string16 PluginInstaller::GetLinkText() { 74 string16 PluginInstaller::GetLinkText() {
71 return l10n_util::GetStringUTF16(IDS_PLUGININSTALLER_PROBLEMSINSTALLING); 75 return l10n_util::GetStringUTF16(IDS_PLUGININSTALLER_PROBLEMSINSTALLING);
72 } 76 }
73 77
74 bool PluginInstaller::LinkClicked(WindowOpenDisposition disposition) { 78 bool PluginInstaller::LinkClicked(WindowOpenDisposition disposition) {
75 // Ignore the click dispostion and always open in a new top level tab. 79 // Ignore the click dispostion and always open in a new top level tab.
76 tab_contents_->OpenURL( 80 tab_contents_->OpenURL(GURL(kLearnMorePluginInstallerUrl), GURL(),
77 GURL(l10n_util::GetStringUTF8(IDS_LEARN_MORE_PLUGININSTALLER_URL)), 81 NEW_FOREGROUND_TAB, PageTransition::LINK);
78 GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
79 return false; // Do not dismiss the info bar. 82 return false; // Do not dismiss the info bar.
80 } 83 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698