Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 4128014: Update archive_build to push prebuilts to Google storage land. (Closed)

Created:
10 years, 1 month ago by scottz
Modified:
9 years, 7 months ago
Reviewers:
anush, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils
Visibility:
Public.

Description

Update archive_build to push prebuilts to Google storage land. Enabled host prebuilt upload on the x86-generic target. BUG=NA TEST=Tested on an x86-generic build to ensure it uploads as expected Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=695adf1

Patch Set 1 #

Patch Set 2 : Add in readlink change #

Total comments: 4

Patch Set 3 : update for comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M archive_build.sh View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottz
10 years, 1 month ago (2010-10-28 22:14:22 UTC) #1
sosa
http://codereview.chromium.org/4128014/diff/2001/3001 File archive_build.sh (right): http://codereview.chromium.org/4128014/diff/2001/3001#newcode269 archive_build.sh:269: # this will upload prebuilt packages to Google Storage ...
10 years, 1 month ago (2010-10-28 22:18:36 UTC) #2
scottz
http://codereview.chromium.org/4128014/diff/2001/3001 File archive_build.sh (right): http://codereview.chromium.org/4128014/diff/2001/3001#newcode269 archive_build.sh:269: # this will upload prebuilt packages to Google Storage ...
10 years, 1 month ago (2010-10-28 23:11:03 UTC) #3
sosa
LGTM On Thu, Oct 28, 2010 at 4:11 PM, <scottz@chromium.org> wrote: > > http://codereview.chromium.org/4128014/diff/2001/3001 > ...
10 years, 1 month ago (2010-10-28 23:16:39 UTC) #4
anush
10 years, 1 month ago (2010-10-28 23:51:20 UTC) #5
LGTM

On Thu, Oct 28, 2010 at 4:16 PM, Chris Sosa <sosa@chromium.org> wrote:
> LGTM
>
> On Thu, Oct 28, 2010 at 4:11 PM,  <scottz@chromium.org> wrote:
>>
>> http://codereview.chromium.org/4128014/diff/2001/3001
>> File archive_build.sh (right):
>>
>> http://codereview.chromium.org/4128014/diff/2001/3001#newcode269
>> archive_build.sh:269: # this will upload prebuilt packages to Google
>> Storage
>> On 2010/10/28 22:18:36, sosa wrote:
>>>
>>> punctuation
>>
>> Done.
>>
>> http://codereview.chromium.org/4128014/diff/2001/3001#newcode275
>> archive_build.sh:275: then
>> This is special cased since we only want one bot to be uploading the
>> chroot prebuilt as it is shared between all hosts. Traditionally this
>> has been x86-generic so that is what I decided on.
>>
>> On 2010/10/28 22:18:36, sosa wrote:
>>>
>>> What's the special case for
>>
>> http://codereview.chromium.org/4128014/show
>>
>

Powered by Google App Engine
This is Rietveld 408576698