Issue 4127013: Refactor ChangeInfo.Load() to make it easier to support mulitple format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4127013: Refactor ChangeInfo.Load() to make it easier to support mulitple format. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Refactor ChangeInfo.Load() to make it easier to support mulitple format. TEST=updated unit tests and tested manually BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64601

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -21 lines)			Patch
	M	gcl.py	View		4 chunks	+34 lines, -13 lines	2 comments	Download
	M	tests/gcl_unittest.py	View		4 chunks	+18 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm http://codereview.chromium.org/4127013/diff/1/2 File gcl.py (right): http://codereview.chromium.org/4127013/diff/1/2#newcode34 gcl.py:34: sys.path.append(os.path.join(os.path.dirname(__file__), 'third_party')) since this is part of depot_tools ...

10 years, 1 month ago (2010-10-29 18:29:33 UTC) #2

M-A Ruel

10 years, 1 month ago (2010-11-01 13:33:01 UTC) #3

http://codereview.chromium.org/4127013/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/4127013/diff/1/2#newcode34
gcl.py:34: sys.path.append(os.path.join(os.path.dirname(__file__),
'third_party'))
On 2010/10/29 18:29:33, jochen wrote:
> since this is part of depot_tools anyway, why not just always use that one?

I wanted to use the included copy at last resort but I agree it's no big deal
anyway. I just copied with trychange.py is doing already. It could changed in a
follow up review.

Expand Messages | Collapse Messages