Modified chrome pageload extension

-Add the option to export the result table to .csv format.
-Add the option to clear selected data sets.
-Add the option to sort the result table according to the chosen metric.
-Move "load from file" button to the same line of Url text box.
-Highlight the tested page to trigger the paint event.
-Include third party libraries table2CSV.js and sorttable.js in util folder.
-Remove some redundant scripts from jquery folder.
-Prune sorttable.js to remove some browser specific code.

Contributed by Jianxia Ning <jning@google.com>;. 

BUG=none 
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64180

[lzheng, 2010-10-26 20:06:47]

http://codereview.chromium.org/4123001/diff/1/3
File jquery/table2CSV.js (right):

http://codereview.chromium.org/4123001/diff/1/3#newcode1
jquery/table2CSV.js:1: jQuery.fn.table2CSV = function(rowNum,options) {
Is it okay to call this function table2CSV and move it out of the jquery
directory?

http://codereview.chromium.org/4123001/diff/1/3#newcode23
jquery/table2CSV.js:23: if (index > 0 && $(this).css('display') != 'none')
tmpRow[tmpRow.length] = formatData($(this).html());
try to limit it to 80 chars

http://codereview.chromium.org/4123001/diff/1/3#newcode34
jquery/table2CSV.js:34: if (index > 0 && $(this).css('display') != 'none')
tmpRow[tmpRow.length] = formatData($(this).html());
80 chars.

http://codereview.chromium.org/4123001/diff/1/4
File options.html (right):

http://codereview.chromium.org/4123001/diff/1/4#newcode15
options.html:15: <script src="jquery/sorttable.js"
type="text/javascript"></script>
Why do you put these two files under jquery? I assume jquery/ contains files
from jquery. So, would it be reasonable to put these two files somewhere else?

[jning, 2010-10-26 22:02:19]

http://codereview.chromium.org/4123001/diff/1/3
File jquery/table2CSV.js (right):

http://codereview.chromium.org/4123001/diff/1/3#newcode1
jquery/table2CSV.js:1: jQuery.fn.table2CSV = function(rowNum,options) {
This func is contributed by others, with some modification from me. There are
quite a few functions in this script, moving all of them to options.html may be
a burden. And also the jquery folder contains not only jquery script, also the
plotting and sorting scripts. How about we merge the two folders and all scripts
are in jst folder? 
On 2010/10/26 20:06:48, lzheng wrote:
> Is it okay to call this function table2CSV and move it out of the jquery
> directory?

http://codereview.chromium.org/4123001/diff/1/4
File options.html (right):

http://codereview.chromium.org/4123001/diff/1/4#newcode15
options.html:15: <script src="jquery/sorttable.js"
type="text/javascript"></script>
Actually the flot scripts are not jquery scripts either. How about merging the
jst and jquery folders? Or rename the jquery folder. Also--Seems these scripts
put on much weight to the extension, the original .crx is only 40+ KB, now it is
1000 KB. Is it better to cut off some part from the scripts which we do not
utilize (those serve for generality purpose) or keep it as general as it is?

On 2010/10/26 20:06:48, lzheng wrote:
> Why do you put these two files under jquery? I assume jquery/ contains files
> from jquery. So, would it be reasonable to put these two files somewhere else?

[lzheng1, 2010-10-26 22:12:06]

On Tue, Oct 26, 2010 at 3:02 PM, <jning@google.com> wrote:

>
> http://codereview.chromium.org/4123001/diff/1/3
> File jquery/table2CSV.js (right):
>
> http://codereview.chromium.org/4123001/diff/1/3#newcode1
> jquery/table2CSV.js:1: jQuery.fn.table2CSV = function(rowNum,options) {
> This func is contributed by others, with some modification from me.
> There are quite a few functions in this script, moving all of them to
> options.html may be a burden. And also the jquery folder contains not
> only jquery script, also the plotting and sorting scripts. How about we
> merge the two folders and all scripts are in jst folder?
>
> On 2010/10/26 20:06:48, lzheng wrote:
>
>> Is it okay to call this function table2CSV and move it out of the
>>
> jquery
>
>> directory?
>>
>
> http://codereview.chromium.org/4123001/diff/1/4
> File options.html (right):
>
> http://codereview.chromium.org/4123001/diff/1/4#newcode15
> options.html:15: <script src="jquery/sorttable.js"
> type="text/javascript"></script>
> Actually the flot scripts are not jquery scripts either. How about
> merging the jst and jquery folders? Or rename the jquery folder.
> Also--Seems these scripts put on much weight to the extension, the
> original .crx is only 40+ KB, now it is 1000 KB. Is it better to cut off
> some part from the scripts which we do not utilize (those serve for
> generality purpose) or keep it as general as it is?
>
>
> On 2010/10/26 20:06:48, lzheng wrote:
>
>> Why do you put these two files under jquery? I assume jquery/ contains
>>
> files
>
>> from jquery. So, would it be reasonable to put these two files
>>
> somewhere else?
>
> http://codereview.chromium.org/4123001/show
>

Is it possible to keep jquery files in its own folder but keep ours in a
different folder? Also, be careful about the third part free code. We need
to exam the licensing terms and see if we are okay to modify and
re-distribute. Can you make sure the code you used follow the licensing
agreement?
I like the idea to make the package smaller by keeping only used package.
But in that case, we should have a readme to note what is included and what
is not, so later when someone wants to update the package, he/she knows what
to look.

[jning, 2010-10-26 22:38:31]

Thanks for the reminder. I did not realize the copyright issue. The good news is
all of them grant permission to modify and redistribute. How about we put
table2CSV.js and sorttable.js in a 'util' folder, and I prune the scripts and
put some necessary comments in script and include a readme about where to find
the original file and what parts are modified & removed?
On 2010/10/26 22:12:06, lzheng1 wrote:
> On Tue, Oct 26, 2010 at 3:02 PM, <mailto:jning@google.com> wrote:
> 
> >
> > http://codereview.chromium.org/4123001/diff/1/3
> > File jquery/table2CSV.js (right):
> >
> > http://codereview.chromium.org/4123001/diff/1/3#newcode1
> > jquery/table2CSV.js:1: jQuery.fn.table2CSV = function(rowNum,options) {
> > This func is contributed by others, with some modification from me.
> > There are quite a few functions in this script, moving all of them to
> > options.html may be a burden. And also the jquery folder contains not
> > only jquery script, also the plotting and sorting scripts. How about we
> > merge the two folders and all scripts are in jst folder?
> >
> > On 2010/10/26 20:06:48, lzheng wrote:
> >
> >> Is it okay to call this function table2CSV and move it out of the
> >>
> > jquery
> >
> >> directory?
> >>
> >
> > http://codereview.chromium.org/4123001/diff/1/4
> > File options.html (right):
> >
> > http://codereview.chromium.org/4123001/diff/1/4#newcode15
> > options.html:15: <script src="jquery/sorttable.js"
> > type="text/javascript"></script>
> > Actually the flot scripts are not jquery scripts either. How about
> > merging the jst and jquery folders? Or rename the jquery folder.
> > Also--Seems these scripts put on much weight to the extension, the
> > original .crx is only 40+ KB, now it is 1000 KB. Is it better to cut off
> > some part from the scripts which we do not utilize (those serve for
> > generality purpose) or keep it as general as it is?
> >
> >
> > On 2010/10/26 20:06:48, lzheng wrote:
> >
> >> Why do you put these two files under jquery? I assume jquery/ contains
> >>
> > files
> >
> >> from jquery. So, would it be reasonable to put these two files
> >>
> > somewhere else?
> >
> > http://codereview.chromium.org/4123001/show
> >
> 
> Is it possible to keep jquery files in its own folder but keep ours in a
> different folder? Also, be careful about the third part free code. We need
> to exam the licensing terms and see if we are okay to modify and
> re-distribute. Can you make sure the code you used follow the licensing
> agreement?
> I like the idea to make the package smaller by keeping only used package.
> But in that case, we should have a readme to note what is included and what
> is not, so later when someone wants to update the package, he/she knows what
> to look.
>

[lzheng1, 2010-10-26 22:41:57]

Sounds good.

On Tue, Oct 26, 2010 at 3:38 PM, <jning@google.com> wrote:

> Thanks for the reminder. I did not realize the copyright issue. The good
> news is
> all of them grant permission to modify and redistribute. How about we put
> table2CSV.js and sorttable.js in a 'util' folder, and I prune the scripts
> and
> put some necessary comments in script and include a readme about where to
> find
> the original file and what parts are modified & removed?
> On 2010/10/26 22:12:06, lzheng1 wrote:
>
>  On Tue, Oct 26, 2010 at 3:02 PM, <mailto:jning@google.com> wrote:
>>
>
>  >
>> > http://codereview.chromium.org/4123001/diff/1/3
>> > File jquery/table2CSV.js (right):
>> >
>> > http://codereview.chromium.org/4123001/diff/1/3#newcode1
>> > jquery/table2CSV.js:1: jQuery.fn.table2CSV = function(rowNum,options) {
>> > This func is contributed by others, with some modification from me.
>> > There are quite a few functions in this script, moving all of them to
>> > options.html may be a burden. And also the jquery folder contains not
>> > only jquery script, also the plotting and sorting scripts. How about we
>> > merge the two folders and all scripts are in jst folder?
>> >
>> > On 2010/10/26 20:06:48, lzheng wrote:
>> >
>> >> Is it okay to call this function table2CSV and move it out of the
>> >>
>> > jquery
>> >
>> >> directory?
>> >>
>> >
>> > http://codereview.chromium.org/4123001/diff/1/4
>> > File options.html (right):
>> >
>> > http://codereview.chromium.org/4123001/diff/1/4#newcode15
>> > options.html:15: <script src="jquery/sorttable.js"
>> > type="text/javascript"></script>
>> > Actually the flot scripts are not jquery scripts either. How about
>> > merging the jst and jquery folders? Or rename the jquery folder.
>> > Also--Seems these scripts put on much weight to the extension, the
>> > original .crx is only 40+ KB, now it is 1000 KB. Is it better to cut off
>> > some part from the scripts which we do not utilize (those serve for
>> > generality purpose) or keep it as general as it is?
>> >
>> >
>> > On 2010/10/26 20:06:48, lzheng wrote:
>> >
>> >> Why do you put these two files under jquery? I assume jquery/ contains
>> >>
>> > files
>> >
>> >> from jquery. So, would it be reasonable to put these two files
>> >>
>> > somewhere else?
>> >
>> > http://codereview.chromium.org/4123001/show
>> >
>>
>
>  Is it possible to keep jquery files in its own folder but keep ours in a
>> different folder? Also, be careful about the third part free code. We need
>> to exam the licensing terms and see if we are okay to modify and
>> re-distribute. Can you make sure the code you used follow the licensing
>> agreement?
>> I like the idea to make the package smaller by keeping only used package.
>> But in that case, we should have a readme to note what is included and
>> what
>> is not, so later when someone wants to update the package, he/she knows
>> what
>> to look.
>>
>
>
>
>
> http://codereview.chromium.org/4123001/show
>

[jning, 2010-10-27 03:34:52]

Changes:
-Acknowledge the third-party libraries in README.txt.
-Remove some redundant scripts from jquery folder. 
-Replace jquery.flot.js with a lightweight alternative jquery.flot.min.js.
-Put sorttable.js and table2CSV.js into a new folder util and add comments in
the scripts about the modification and removed parts.

Sorry that I did not emphasize I use third-party libraries and was not aware
they need special handling. Please indicate if there is anything additional I
should do about it. Thank you.
 
On 2010/10/26 22:41:57, lzheng1 wrote:
> Sounds good.
> 
> On Tue, Oct 26, 2010 at 3:38 PM, <mailto:jning@google.com> wrote:
> 
> > Thanks for the reminder. I did not realize the copyright issue. The good
> > news is
> > all of them grant permission to modify and redistribute. How about we put
> > table2CSV.js and sorttable.js in a 'util' folder, and I prune the scripts
> > and
> > put some necessary comments in script and include a readme about where to
> > find
> > the original file and what parts are modified & removed?
> > On 2010/10/26 22:12:06, lzheng1 wrote:
> >
> >  On Tue, Oct 26, 2010 at 3:02 PM, <mailto:jning@google.com> wrote:
> >>
> >
> >  >
> >> > http://codereview.chromium.org/4123001/diff/1/3
> >> > File jquery/table2CSV.js (right):
> >> >
> >> > http://codereview.chromium.org/4123001/diff/1/3#newcode1
> >> > jquery/table2CSV.js:1: jQuery.fn.table2CSV = function(rowNum,options) {
> >> > This func is contributed by others, with some modification from me.
> >> > There are quite a few functions in this script, moving all of them to
> >> > options.html may be a burden. And also the jquery folder contains not
> >> > only jquery script, also the plotting and sorting scripts. How about we
> >> > merge the two folders and all scripts are in jst folder?
> >> >
> >> > On 2010/10/26 20:06:48, lzheng wrote:
> >> >
> >> >> Is it okay to call this function table2CSV and move it out of the
> >> >>
> >> > jquery
> >> >
> >> >> directory?
> >> >>
> >> >
> >> > http://codereview.chromium.org/4123001/diff/1/4
> >> > File options.html (right):
> >> >
> >> > http://codereview.chromium.org/4123001/diff/1/4#newcode15
> >> > options.html:15: <script src="jquery/sorttable.js"
> >> > type="text/javascript"></script>
> >> > Actually the flot scripts are not jquery scripts either. How about
> >> > merging the jst and jquery folders? Or rename the jquery folder.
> >> > Also--Seems these scripts put on much weight to the extension, the
> >> > original .crx is only 40+ KB, now it is 1000 KB. Is it better to cut off
> >> > some part from the scripts which we do not utilize (those serve for
> >> > generality purpose) or keep it as general as it is?
> >> >
> >> >
> >> > On 2010/10/26 20:06:48, lzheng wrote:
> >> >
> >> >> Why do you put these two files under jquery? I assume jquery/ contains
> >> >>
> >> > files
> >> >
> >> >> from jquery. So, would it be reasonable to put these two files
> >> >>
> >> > somewhere else?
> >> >
> >> > http://codereview.chromium.org/4123001/show
> >> >
> >>
> >
> >  Is it possible to keep jquery files in its own folder but keep ours in a
> >> different folder? Also, be careful about the third part free code. We need
> >> to exam the licensing terms and see if we are okay to modify and
> >> re-distribute. Can you make sure the code you used follow the licensing
> >> agreement?
> >> I like the idea to make the package smaller by keeping only used package.
> >> But in that case, we should have a readme to note what is included and
> >> what
> >> is not, so later when someone wants to update the package, he/she knows
> >> what
> >> to look.
> >>
> >
> >
> >
> >
> > http://codereview.chromium.org/4123001/show
> >
>

[lzheng, 2010-10-27 16:42:27]

LGTM.

On 2010/10/27 03:34:52, jning wrote:
> Changes:
> -Acknowledge the third-party libraries in README.txt.
> -Remove some redundant scripts from jquery folder. 
> -Replace jquery.flot.js with a lightweight alternative jquery.flot.min.js.
> -Put sorttable.js and table2CSV.js into a new folder util and add comments in
> the scripts about the modification and removed parts.
> 
> Sorry that I did not emphasize I use third-party libraries and was not aware
> they need special handling. Please indicate if there is anything additional I
> should do about it. Thank you.
>  
> On 2010/10/26 22:41:57, lzheng1 wrote:
> > Sounds good.
> > 
> > On Tue, Oct 26, 2010 at 3:38 PM, <mailto:jning@google.com> wrote:
> > 
> > > Thanks for the reminder. I did not realize the copyright issue. The good
> > > news is
> > > all of them grant permission to modify and redistribute. How about we put
> > > table2CSV.js and sorttable.js in a 'util' folder, and I prune the scripts
> > > and
> > > put some necessary comments in script and include a readme about where to
> > > find
> > > the original file and what parts are modified & removed?
> > > On 2010/10/26 22:12:06, lzheng1 wrote:
> > >
> > >  On Tue, Oct 26, 2010 at 3:02 PM, <mailto:jning@google.com> wrote:
> > >>
> > >
> > >  >
> > >> > http://codereview.chromium.org/4123001/diff/1/3
> > >> > File jquery/table2CSV.js (right):
> > >> >
> > >> > http://codereview.chromium.org/4123001/diff/1/3#newcode1
> > >> > jquery/table2CSV.js:1: jQuery.fn.table2CSV = function(rowNum,options) {
> > >> > This func is contributed by others, with some modification from me.
> > >> > There are quite a few functions in this script, moving all of them to
> > >> > options.html may be a burden. And also the jquery folder contains not
> > >> > only jquery script, also the plotting and sorting scripts. How about we
> > >> > merge the two folders and all scripts are in jst folder?
> > >> >
> > >> > On 2010/10/26 20:06:48, lzheng wrote:
> > >> >
> > >> >> Is it okay to call this function table2CSV and move it out of the
> > >> >>
> > >> > jquery
> > >> >
> > >> >> directory?
> > >> >>
> > >> >
> > >> > http://codereview.chromium.org/4123001/diff/1/4
> > >> > File options.html (right):
> > >> >
> > >> > http://codereview.chromium.org/4123001/diff/1/4#newcode15
> > >> > options.html:15: <script src="jquery/sorttable.js"
> > >> > type="text/javascript"></script>
> > >> > Actually the flot scripts are not jquery scripts either. How about
> > >> > merging the jst and jquery folders? Or rename the jquery folder.
> > >> > Also--Seems these scripts put on much weight to the extension, the
> > >> > original .crx is only 40+ KB, now it is 1000 KB. Is it better to cut
off
> > >> > some part from the scripts which we do not utilize (those serve for
> > >> > generality purpose) or keep it as general as it is?
> > >> >
> > >> >
> > >> > On 2010/10/26 20:06:48, lzheng wrote:
> > >> >
> > >> >> Why do you put these two files under jquery? I assume jquery/ contains
> > >> >>
> > >> > files
> > >> >
> > >> >> from jquery. So, would it be reasonable to put these two files
> > >> >>
> > >> > somewhere else?
> > >> >
> > >> > http://codereview.chromium.org/4123001/show
> > >> >
> > >>
> > >
> > >  Is it possible to keep jquery files in its own folder but keep ours in a
> > >> different folder? Also, be careful about the third part free code. We
need
> > >> to exam the licensing terms and see if we are okay to modify and
> > >> re-distribute. Can you make sure the code you used follow the licensing
> > >> agreement?
> > >> I like the idea to make the package smaller by keeping only used package.
> > >> But in that case, we should have a readme to note what is included and
> > >> what
> > >> is not, so later when someone wants to update the package, he/she knows
> > >> what
> > >> to look.
> > >>
> > >
> > >
> > >
> > >
> > > http://codereview.chromium.org/4123001/show
> > >
> >

[jning, 2010-10-27 17:10:29]

One small patch: Highlight/Select the tested page to trigger the paint event.

[lzheng1, 2010-10-27 22:58:07]

Jianxia:

Can you include this file in the original change list? Looks like you
removed other files in your change so the patch now only shows one file. You
can include all of them together.


Lei

On Wed, Oct 27, 2010 at 10:10 AM, <jning@google.com> wrote:

> One small patch: Highlight/Select the tested page to trigger the paint
> event.
>
>
> http://codereview.chromium.org/4123001/show
>

[jning, 2010-10-27 23:14:20]

Done. Thanks!

On 2010/10/27 22:58:07, lzheng1 wrote:
> Jianxia:
> 
> Can you include this file in the original change list? Looks like you
> removed other files in your change so the patch now only shows one file. You
> can include all of them together.
> 
> 
> Lei
> 
> On Wed, Oct 27, 2010 at 10:10 AM, <mailto:jning@google.com> wrote:
> 
> > One small patch: Highlight/Select the tested page to trigger the paint
> > event.
> >
> >
> > http://codereview.chromium.org/4123001/show
> >
>

[lzheng1, 2010-10-27 23:38:05]

Great. Committed.

On Wed, Oct 27, 2010 at 4:14 PM, <jning@google.com> wrote:

> Done. Thanks!
>
>
> On 2010/10/27 22:58:07, lzheng1 wrote:
>
>> Jianxia:
>>
>
>  Can you include this file in the original change list? Looks like you
>> removed other files in your change so the patch now only shows one file.
>> You
>> can include all of them together.
>>
>
>
>  Lei
>>
>
>  On Wed, Oct 27, 2010 at 10:10 AM, <mailto:jning@google.com> wrote:
>>
>
>  > One small patch: Highlight/Select the tested page to trigger the paint
>> > event.
>> >
>> >
>> > http://codereview.chromium.org/4123001/show
>> >
>>
>
>
>
>
> http://codereview.chromium.org/4123001/show
>

[Aaron Boodman, 2010-11-02 22:28:27]

Sorry, but I had to revert r64493 because it broke
chrome/common/extensions/build/build.py. I think it is because of the literal
unicode characters inline in some of the sample code, but I didn't have time to
investigate.

tessamac (cc'd) is going to file a bug with some more details.

Sorry again for the inconvenience.

[Aaron Boodman, 2010-11-02 22:29:04]

On 2010/11/02 22:28:27, Aaron Boodman wrote:
> chrome/common/extensions/build/build.py.

chrome/common/extensions/docs/build/build.py

[Tessa MacDuff, 2010-11-02 23:02:30]

The bug is http://crbug.com/61650.

On Tue, Nov 2, 2010 at 15:28, <aa@chromium.org> wrote:

> Sorry, but I had to revert r64493 because it broke
> chrome/common/extensions/build/build.py. I think it is because of the
> literal
> unicode characters inline in some of the sample code, but I didn't have
> time to
> investigate.
>
> tessamac (cc'd) is going to file a bug with some more details.
>
> Sorry again for the inconvenience.
>
>
> http://codereview.chromium.org/4123001/show
>