Fixes up warning about const NSTypes from presubmit message. Gets rid of leak of font.

chrome/common/sandbox_mac_fontloading_unittest.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/mac/scoped_cftyperef.h"
 #include "base/scoped_ptr.h"
@@ skipping 108 matching lines @@
   ATSFontContainerRef font_container;
   if (!FontLoader::ATSFontContainerFromBuffer(shmem_handle, font_data_length_,
           &font_container)) {
     LOG(ERROR) << "Call to CreateCGFontFromBuffer() failed";
     return false;
   }
 
   // Unload the font container when done.
   ScopedFontContainer scoped_unloader(font_container);
 
-  CGFontRef font_ref;
-  if (!CGFontFromFontContainer(font_container, &font_ref)) {
+  CGFontRef cg_font_ref;
+  if (!CGFontFromFontContainer(font_container, &cg_font_ref)) {
     LOG(ERROR) << "CGFontFromFontContainer failed";
     return false;
   }
 
-  if (!font_ref) {
+  if (!cg_font_ref) {
     LOG(ERROR) << "Got NULL CGFontRef";
     return false;
   }
-  base::mac::ScopedCFTypeRef<CGFontRef> cgfont;
-  cgfont.reset(font_ref);
+  base::mac::ScopedCFTypeRef<CGFontRef> cgfont(cg_font_ref);
 
-  const NSFont* nsfont = reinterpret_cast<const NSFont*>(
-                         CTFontCreateWithGraphicsFont(cgfont.get(), 16.0,
-                            NULL, NULL));
-  if (!nsfont) {
+  CTFontRef ct_font_ref =
+      CTFontCreateWithGraphicsFont(cgfont.get(), 16.0, NULL, NULL);
+  base::mac::ScopedCFTypeRef<CTFontRef> ctfont(ct_font_ref);
+
+  if (!ct_font_ref) {
     LOG(ERROR) << "CTFontCreateWithGraphicsFont() failed";
     return false;
   }
 
   // Do something with the font to make sure it's loaded.
-  CGFloat cap_height = [nsfont capHeight];
+  CGFloat cap_height = CTFontGetCapHeight(ct_font_ref);
 
   if (cap_height <= 0.0) {
-    LOG(ERROR) << "Got bad value for [NSFont capHeight] " << cap_height;
+    LOG(ERROR) << "Got bad value for CTFontGetCapHeight " << cap_height;
     return false;
   }
 
   return true;
 }
 
 TEST_F(MacSandboxTest, FontLoadingTest) {
   FilePath temp_file_path;
   FILE* temp_file = file_util::CreateAndOpenTemporaryFile(&temp_file_path);
   ASSERT_TRUE(temp_file);
   file_util::ScopedFILE temp_file_closer(temp_file);
 
   base::SharedMemory font_data;
   uint32 font_data_size;
   NSFont* srcFont = [NSFont fontWithName:@"Geeza Pro" size:16.0];
   EXPECT_TRUE(FontLoader::LoadFontIntoBuffer(srcFont,
                   &font_data, &font_data_size));
   EXPECT_GT(font_data_size, 0U);
 
   file_util::WriteFileDescriptor(fileno(temp_file),
       static_cast<const char *>(font_data.memory()), font_data_size);
 
   ASSERT_TRUE(RunTestInSandbox(sandbox::SANDBOX_TYPE_RENDERER,
                   "FontLoadingTestCase", temp_file_path.value().c_str()));
   temp_file_closer.reset();
   ASSERT_TRUE(file_util::Delete(temp_file_path, false));
 }
 
 }  // namespace