Chromium Code Reviews

Issue 4116005: Make ExternalizeStringExtension free its data on exit to please (Closed)

Created:
10 years, 1 month ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Add gc() calls to some tests to please valgrind. Committed: http://code.google.com/p/v8/source/detail?r=5724

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Stats (+45 lines, -27 lines)
M src/execution.cc View 2 chunks +2 lines, -0 lines 0 comments
M test/mjsunit/string-externalize.js View 2 chunks +5 lines, -1 line 0 comments
M test/mjsunit/string-replace-with-empty.js View 1 chunk +38 lines, -26 lines 0 comments

Messages

Total messages: 3 (0 generated)
Erik Corry
10 years, 1 month ago (2010-10-27 10:38:53 UTC) #1
Erik Corry
10 years, 1 month ago (2010-10-27 11:24:36 UTC) #2
Vitaly Repeshko
10 years, 1 month ago (2010-10-27 11:26:27 UTC) #3
LGTM. Please update the patch description before submitting.

http://codereview.chromium.org/4116005/diff/6001/7003
File test/mjsunit/string-replace-with-empty.js (right):

http://codereview.chromium.org/4116005/diff/6001/7003#newcode67
test/mjsunit/string-replace-with-empty.js:67: // a memory leak.
Mention valgrind here as well.

Powered by Google App Engine