Issue 4116005: Make ExternalizeStringExtension free its data on exit to please

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4116005: Make ExternalizeStringExtension free its data on exit to please (Closed)

Created:
10 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add gc() calls to some tests to please valgrind. Committed: http://code.google.com/p/v8/source/detail?r=5724

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -27 lines)			Patch
M	src/execution.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/string-externalize.js	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	test/mjsunit/string-replace-with-empty.js	View	2	1 chunk	+38 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 1 month ago (2010-10-27 11:26:27 UTC) #3

LGTM. Please update the patch description before submitting.

http://codereview.chromium.org/4116005/diff/6001/7003
File test/mjsunit/string-replace-with-empty.js (right):

http://codereview.chromium.org/4116005/diff/6001/7003#newcode67
test/mjsunit/string-replace-with-empty.js:67: // a memory leak.
Mention valgrind here as well.

Expand Messages | Collapse Messages