Issue 4114002: cashew: data plans: used bytes should be optional for unlimited plans

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4114002: cashew: data plans: used bytes should be optional for unlimited plans (Closed)

Created:
10 years, 1 month ago by Vince Laviano

Modified:
9 years ago

Reviewers:
Jason Glasgow

CC:
chromium-os-reviews_chromium.org, Vince Laviano

Base URL:
ssh://git@gitrw.chromium.org:9222/cashew.git

Visibility:
Public.

Description

cashew: data plans: used bytes should be optional for unlimited plans BUG=chromium-os:8231, chromium-os:7775 TEST=unit tests Change-Id: I2042c7fe4c8cd93172a8719fd8da020bc164cb7b Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cdca146

Patch Set 2 : jglasgow review fixes #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -7 lines)			Patch
	M	src/data_plan.cc	View	1	2 chunks	+12 lines, -3 lines	0 comments	Download
	M	src/data_plan_unittest.cc	View		2 chunks	+124 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jason Glasgow

LGTM after you fix the typo/nit. http://codereview.chromium.org/4114002/diff/1/2 File src/data_plan.cc (right): http://codereview.chromium.org/4114002/diff/1/2#newcode170 src/data_plan.cc:170: LOG(WARNING) << "FromDictionaryValue: ...

10 years, 1 month ago (2010-10-27 18:54:07 UTC) #2

Vince Laviano

10 years, 1 month ago (2010-10-27 19:14:01 UTC) #3

http://codereview.chromium.org/4114002/diff/1/2
File src/data_plan.cc (right):

http://codereview.chromium.org/4114002/diff/1/2#newcode170
src/data_plan.cc:170: LOG(WARNING) << "FromDictionaryValue: no used byes
property";
On 2010/10/27 18:54:07, Jason Glasgow wrote:
> /byes/bytes
> Also two lines below.

Done. Thanks for catching this.

http://codereview.chromium.org/4114002/diff/1/3
File src/data_plan_unittest.cc (right):

http://codereview.chromium.org/4114002/diff/1/3#newcode53
src/data_plan_unittest.cc:53: "\"usedBytes\" : 52428800,"
On 2010/10/27 18:54:07, Jason Glasgow wrote:
> Can you add a test that has fields > 2GB and > 4GB?
> 
> I guess that might need to wait for the JSON fixes.
> 

Yes. Once this goes in, I plan to begin working on issue 7774 (the JSON fix). As
part of that CL, I'll be sure to include unit tests with byte counts that
overflow signed and unsigned 32 bit ints.

Expand Messages | Collapse Messages

Issue 4114002: cashew: data plans: used bytes should be optional for unlimited plans (Closed)

Description

Patch Set 1 #

Patch Set 2 : jglasgow review fixes #

Messages