Issue 4113004: autotest: Test new crash_reporter error diagnostics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4113004: autotest: Test new crash_reporter error diagnostics (Closed)

Created:
10 years, 1 month ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

autotest: Test new crash_reporter error diagnostics Change-Id: Ie3d8b05e2eed24bd6e70b1e45ab15fc21b34688a BUG=6299, 7782 TEST=Run these tests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1a894e0

Patch Set 1 #

Patch Set 2 : Add signature for error logs #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -51 lines)			Patch
M	client/bin/site_crash_test.py	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	client/site_tests/logging_CrashSender/logging_CrashSender.py	View		5 chunks	+22 lines, -3 lines	0 comments	Download
M	client/site_tests/logging_KernelCrash/logging_KernelCrash.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/site_tests/logging_UserCrash/logging_UserCrash.py	View	1	10 chunks	+120 lines, -43 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 1 month ago (2010-10-28 22:30:50 UTC) #2

LGTM

http://codereview.chromium.org/4113004/diff/3001/4004
File client/site_tests/logging_UserCrash/logging_UserCrash.py (right):

http://codereview.chromium.org/4113004/diff/3001/4004#newcode449
client/site_tests/logging_UserCrash/logging_UserCrash.py:449: utils.system('echo
"%s %s" > %s' % (old_core_pattern, test_option,
You could use utils.write_one_line here and below.

Expand Messages | Collapse Messages