Issue 4111006: AU: No need to calculate SHA-256 on the payload twice for delta updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4111006: AU: No need to calculate SHA-256 on the payload twice for delta updates. (Closed)

Created:
10 years, 1 month ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr, jrbarnette

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: No need to calculate SHA-256 on the payload twice for delta updates. BUG=8200 TEST=unit test; tested on device Change-Id: Ie8dcd3984c858ebf398f56c4e1a1dba31c95c700 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cdc20a9

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	download_action.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 1 month ago (2010-10-27 21:02:12 UTC) #2

LGTM

On Wed, Oct 27, 2010 at 1:49 PM, <petkov@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> AU: No need to calculate SHA-256 on the payload twice for delta updates.
>
> BUG=8200
> TEST=unit test; tested on device
>
> Change-Id: Ie8dcd3984c858ebf398f56c4e1a1dba31c95c700
>
> Please review this at http://codereview.chromium.org/4111006/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/update_engine.git
>
> Affected files:
>  M download_action.cc
>
>
> Index: download_action.cc
> diff --git a/download_action.cc b/download_action.cc
> index
>
bb5d18938c7d302a0c062455ab40a9b0fd3d8102..c17d7e26f7af1a17c5b440477e7ae79788e0ff67
> 100644
> --- a/download_action.cc
> +++ b/download_action.cc
> @@ -123,7 +123,10 @@ void DownloadAction::ReceivedBytes(HttpFetcher
> *fetcher,
>     processor_->ActionComplete(this, kActionCodeDownloadWriteError);
>     return;
>   }
> -  omaha_hash_calculator_.Update(bytes, length);
> +  // DeltaPerformer checks the hashes for delta updates.
> +  if (install_plan_.is_full_update) {
> +    omaha_hash_calculator_.Update(bytes, length);
> +  }
>  }
>
>  namespace {
>
>
>

Expand Messages | Collapse Messages