Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 4107001: Upgraded Mesa to 7.9 from 7.7 in order to pick up bug fixes to the... (Closed)

Created:
10 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, Zhenyao Mo, enne (OOO), jamesr, Stephen White, Vangelis Kokkevis
Visibility:
Public.

Description

Upgraded Mesa to 7.9 from 7.7 in order to pick up bug fixes to the shader compiler which were causing WebGL test timeouts per https://bugs.webkit.org/show_bug.cgi?id=47243 . Version 7.8.2 was too buggy to use. This upgrade required the incorporation of the talloc library, which is only compiled in to the OSMesa shared object produced by third_party/mesa/mesa.gyp and not into the rest of Chromium. Upgraded mesa.gyp for the new source directories and files in Mesa 7.9. Applied the changes originally documented in third_party/mesa/README.chromium to the 7.9 sources. Made other necessary changes to Mesa and talloc to be able to build and run them on Windows and Mac OS X. Created chromium.patch files for both Mesa and talloc. Fixed chrome/gpu/gpu_main.cc to honor the --use-gl command line option on Linux. Tested on Linux in Chromium with CSS 3D content and --use-gl=osmesa as well as in DumpRenderTree and verified that the affected WebGL tests no longer hang. Tested on Windows in Chromium with WebGL content and --use-gl=osmesa. Tested on Mac OS X in test_shell with WebGL content. This job was explicitly not sent to the try bots because it would probably kill them. The files in this CL are a small subset of the files being committed. The patch is too large to upload to Rietveld. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63795

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6197 lines, -2128 lines) Patch
M chrome/gpu/gpu_main.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M third_party/mesa/MesaLib/include/GL/gl.h View 1 2 3 3 chunks +18 lines, -1 line 0 comments Download
M third_party/mesa/MesaLib/include/GL/glext.h View 1 2 3 183 chunks +3182 lines, -1619 lines 0 comments Download
M third_party/mesa/MesaLib/include/GL/glx.h View 1 2 3 3 chunks +23 lines, -16 lines 0 comments Download
M third_party/mesa/MesaLib/include/GL/glxext.h View 1 2 3 37 chunks +155 lines, -95 lines 0 comments Download
M third_party/mesa/MesaLib/include/GL/wglext.h View 1 2 3 33 chunks +138 lines, -106 lines 0 comments Download
A third_party/mesa/MesaLib/src/glsl/safe_strcmp.h View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/mesa/MesaLib/src/glsl/safe_strcmp.c View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/mesa/MesaLib/src/mesa/drivers/osmesa/empty.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/mesa/README.chromium View 1 2 3 2 chunks +51 lines, -25 lines 0 comments Download
A third_party/mesa/chromium.patch View 1 chunk +1835 lines, -0 lines 0 comments Download
M third_party/mesa/mesa.gyp View 1 2 3 2 chunks +363 lines, -265 lines 0 comments Download
A third_party/talloc/README.chromium View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/talloc/chromium.patch View 1 2 3 1 chunk +338 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
10 years, 2 months ago (2010-10-25 21:08:56 UTC) #1
Ken Russell (switch to Gerrit)
Based on review feedback and suggestion from markmentovai, changed mechanism on Mac OS X for ...
10 years, 2 months ago (2010-10-25 21:56:49 UTC) #2
apatrick_chromium
10 years, 2 months ago (2010-10-25 21:58:32 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698