Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 4106014: Tweaks to improve memory consumption by TopSites. The biggest culprit (Closed)

Created:
10 years, 1 month ago by sky
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Tweaks to improve memory consumption by TopSites. The biggest culprit seems to repeatedly querying history during this perf test. So, the biggest gain is made by scaling this back. Here are other tweaks I've made: . decrease the page size/cache size of the two DBs. Now that favicons doesn't store thumbnails the db doesn't need to be so big. . Set a cap to the max number of tmp thumnbails maintains. . Force jpg data vector to be only as big as it needs to be. . Tweak TopSitesCache so it doesn't end up duplicating so many GURLs. This is particularly helpful for long redirect lists. BUG=61487 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64837

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 3

Patch Set 3 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -61 lines) Patch
M chrome/browser/history/thumbnail_database.cc View 1 chunk +4 lines, -15 lines 0 comments Download
M chrome/browser/history/top_sites.h View 1 2 5 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 1 2 8 chunks +56 lines, -23 lines 0 comments Download
M chrome/browser/history/top_sites_cache.h View 1 2 chunks +31 lines, -3 lines 0 comments Download
M chrome/browser/history/top_sites_cache.cc View 1 2 chunks +20 lines, -6 lines 0 comments Download
M chrome/browser/history/top_sites_database.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
10 years, 1 month ago (2010-11-01 21:19:06 UTC) #1
brettw
http://codereview.chromium.org/4106014/diff/2001/3002 File chrome/browser/history/top_sites.cc (right): http://codereview.chromium.org/4106014/diff/2001/3002#newcode208 chrome/browser/history/top_sites.cc:208: // Always remove the existing entry, that way if ...
10 years, 1 month ago (2010-11-01 21:40:21 UTC) #2
sky
All updated with new snapshot uploaded. -Scott
10 years, 1 month ago (2010-11-01 22:04:55 UTC) #3
brettw
10 years, 1 month ago (2010-11-01 22:30:06 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698