Issue 4106011: Refactor ChangeInfo.Load() to make it possible to switch to a new format more easily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4106011: Refactor ChangeInfo.Load() to make it possible to switch to a new format more easily. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Refactor ChangeInfo.Load() to make it possible to switch to a new format more easily. The new format will be introduced in the next change. TEST=not much, mostly manually tested. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64600

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -22 lines)			Patch
	M	gcl.py	View		2 chunks	+34 lines, -22 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

10 years, 1 month ago (2010-10-29 18:25:08 UTC) #2

lgtm

http://codereview.chromium.org/4106011/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/4106011/diff/1/2#newcode2
gcl.py:2: # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
nit non-std license header

Expand Messages | Collapse Messages