crosutils: enable learning board type and setting localaccount

sync_build_test.sh

 #!/bin/bash
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Script to sync your checkout, build a Chromium OS image, and test it all
 # with one command.  Can also check out a new Chromium OS checkout and
 # perform a subset of the above operations.
 #
@@ skipping 26 matching lines @@
 #
 # Environment variables that may be useful:
 #   BUILDBOT_URI - default value for --buildbot_uri
 #   CHROMIUM_REPO - default value for --repo
 #   CHRONOS_PASSWD - default value for --chronos_passwd
 #
 
 # Load common constants.  This should be the first executable line.
 # The path to common.sh should be relative to your script's location.
 . "$(dirname "$0")/common.sh"
+# Allow remote access (for learning board type)
+. "$(dirname "$0")/remote_access.sh"
 
-
-DEFINE_string board "x86-generic" "Board setting"
+DEFINE_string board "" "Board setting"
 DEFINE_boolean build ${FLAGS_TRUE} \
     "Build all code (but not necessarily master image)"
 DEFINE_boolean build_autotest ${FLAGS_FALSE} "Build autotest"
 DEFINE_string buildbot_uri "${BUILDBOT_URI}" \
     "Base URI to buildbot build location which contains LATEST file"
 DEFINE_string chrome_root "" \
     "The root of your chrome browser source. Should contain a 'src' subdir. \
 If this is set, chrome browser will be built from source."
 DEFINE_string chronos_passwd "${CHRONOS_PASSWD}" \
     "Use this as the chronos user passwd (defaults to \$CHRONOS_PASSWD)"
@@ skipping 11 matching lines @@
 DEFINE_string image_to_usb "" \
     "Treat this device as USB and put the image on it after build"
 # You can set jobs > 1 but then your build may break and you may need
 # to retry.  Setting it to 1 is best for non-interactive sessions.
 DEFINE_boolean interactive ${FLAGS_FALSE} \
     "Tell user what we plan to do and wait for input to proceed" i
 DEFINE_integer jobs -1 "Concurrent build jobs"
 DEFINE_boolean master ${FLAGS_TRUE} "Master an image from built code"
 DEFINE_boolean minilayout ${FLAGS_FALSE} "Use minimal code checkout"
 DEFINE_boolean mod_image_for_test ${FLAGS_FALSE} "Modify the image for testing"
-DEFINE_string remote "" \
-    "Use this hostname/IP for live updating and running tests"
 DEFINE_string repo "${CHROMIUMOS_REPO}" "gclient repo for chromiumos"
 DEFINE_boolean sync ${FLAGS_TRUE} "Sync the checkout"
 DEFINE_string test "" \
     "Test the built image with the given params to run_remote_tests"
 DEFINE_string top "" \
     "Root directory of your checkout (defaults to determining from your cwd)"
 DEFINE_boolean withdev ${FLAGS_TRUE} "Build development packages"
 DEFINE_boolean usepkg ${FLAGS_TRUE} "Use binary packages"
 DEFINE_boolean useworkon ${FLAGS_TRUE} "Use cros_workon/repo workflow"
 DEFINE_boolean unittest ${FLAGS_TRUE} "Run unit tests"
 
 # Returns a heuristic indicating if we believe this to be a google internal
 # development environment.
 # Returns:
 #   0 if so, 1 otherwise
 function is_google_environment() {
   hostname | egrep -q .google.com\$
   return $?
 }
 
 
 # Validates parameters and sets "intelligent" defaults based on other
 # parameters.
 function validate_and_set_param_defaults() {
+  TMP=$(mktemp -d "/tmp/sync_build_test.XXXX")
+
   if [[ -z "${FLAGS_top}" ]]; then
     local test_dir=$(pwd)
     while [[ "${test_dir}" != "/" ]]; do
       if [[ -d "${test_dir}/src/platform/dev" ]]; then
         FLAGS_top="${test_dir}"
         break
       fi
       test_dir=$(dirname "${test_dir}")
     done
   fi
@@ skipping 50 matching lines @@
       # built during run_remote_tests, so we need to build them all
       # beforehand.
       FLAGS_build_autotest=${FLAGS_TRUE}
     fi
   fi
 
   # If they gave us a remote host, then we assume they want us to do a live
   # update.
   if [[ -n "${FLAGS_remote}" ]]; then
     FLAGS_image_to_live=${FLAGS_TRUE}
+    remote_access_init
+  fi
+
+  # Figure out board.
+  if [[ -z "${FLAGS_board}" ]]; then
+    if [[ -n "${FLAGS_remote}" ]]; then
+      learn_board
+    else
+      FLAGS_board="${DEFAULT_BOARD}"
+    fi
   fi
 
   # Grabbing a buildbot build is exclusive with syncing and building
   if [[ -n "${FLAGS_grab_buildbot}" ]]; then
     if [[ "${FLAGS_grab_buildbot}" == "LATEST" ]]; then
       if [[ -z "${FLAGS_buildbot_uri}" ]]; then
         echo "--grab_buildbot=LATEST requires --buildbot_uri or setting "
         echo "BUILDBOT_URI"
         exit 1
       fi
@@ skipping 146 matching lines @@
 #   $1 - phase description
 function describe_phase() {
   local desc="$1"
   echo ""
   echo "#"
   echo "#"
   echo "# ${desc}"
   echo "#"
 }
 
+function cleanup() {
+  [ -n "${TMP}" ] && rm -rf "${TMP}"
+  cleanup_remote_access
+}
 
 # Called when there is a failure and we exit early
 function failure() {
   trap - EXIT
   # Clear these out just in case.
   export GSDCURL_USERNAME=""
   export GSDCURL_PASSWORD=""
   describe_phase "Failure during: ${LAST_PHASE}"
   show_duration
+  cleanup
 }
 
 
 # Runs a phase, describing it first, and also updates the sudo timeout
 # afterwards.
 # Arguments:
 #   $1 - phase description
 #   $2.. - command/params to run
 function run_phase() {
   local desc="$1"
@@ skipping 102 matching lines @@
   export GSDCURL_PASSWORD
   CURL="$(dirname $0)/bin/cros_gsdcurl.py"
   if [[ "${FLAGS_grab_buildbot}" == "LATEST" ]]; then
     local latest=$(${CURL} "${FLAGS_buildbot_uri}/LATEST")
     if [[ -z "${latest}" ]]; then
       echo "Error finding latest."
       exit 1
     fi
     FLAGS_grab_buildbot="${FLAGS_buildbot_uri}/${latest}/image.zip"
   fi
-  local dl_dir=$(mktemp -d "/tmp/image.XXXX")
+  local dl_dir="${TMP}/image"
 
   echo "Grabbing image from ${FLAGS_grab_buildbot} to ${dl_dir}"
   run_phase "Downloading image" ${CURL} "${FLAGS_grab_buildbot}" \
     -o "${dl_dir}/image.zip"
   # Clear out the credentials so they can't be used later.
   export GSDCURL_USERNAME=""
   export GSDCURL_PASSWORD=""
 
   cd "${dl_dir}"
   unzip image.zip
@@ skipping 88 matching lines @@
 
   if [[ ${FLAGS_force_make_chroot} -eq ${FLAGS_TRUE} ]]; then
     chdir_relative src/scripts
     local extra_flags="--nouseworkon"
     [[ ${FLAGS_useworkon} -eq ${FLAGS_TRUE} ]] && extra_flags="--useworkon"
     run_phase "Replacing chroot" ./make_chroot ${extra_flags} --replace \
         "--chroot=${FLAGS_chroot}" ${jobs_param}
   fi
 
   if [[ ${FLAGS_build} -eq ${FLAGS_TRUE} ]]; then
+    # It's necessary to enable localaccount for BVT tests to pass.
+    chdir_relative src/scripts
+    run_phase "Enable local account" \
+        ./enable_localaccount.sh chronos "${FLAGS_chroot}"
+
     local pkg_param=""
     if [[ ${FLAGS_usepkg} -eq ${FLAGS_FALSE} ]]; then
       pkg_param="--nousepkg"
     fi
 
     chdir_relative src/scripts
     # Only setup board target if the directory does not exist
     if [[ ! -d "${FLAGS_top}/chroot/build/${FLAGS_board}" ]]; then
       run_phase_in_chroot "Setting up board target" \
           ./setup_board ${pkg_param} "${board_param}"
@@ skipping 63 matching lines @@
     if ! run_phase "Running tests on Chromium OS machine ${FLAGS_remote}" \
       ./run_remote_tests.sh "--remote=${FLAGS_remote}" ${FLAGS_test} \
       "${board_param}"; then
       if [[ ${FLAGS_ignore_remote_test_failures} -eq ${FLAGS_FALSE} ]]; then
         echo "Remote tests failed and --ignore_remote_test_failures not passed"
         false
       fi
     fi
   fi
 
-  trap - EXIT
+  trap cleanup EXIT
   echo "Successfully used ${FLAGS_top} to:"
   describe_steps
   show_duration
 }
 
 
 main $@