Issue 4103002: AU: Implement switching of tracks through SetTrack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4103002: AU: Implement switching of tracks through SetTrack. (Closed)

Created:
10 years, 2 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr, satorux1

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Implement switching of tracks through SetTrack. On official images, update engine allows updating the track only to dev-channel or beta-channel. The track is verified both at setting and at getting time. BUG=8104 TEST=unit test; tested on device Change-Id: Ic81d4e3a9e09554d2239ee5c7a6c78e4dfe30d19 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=49d9132

Patch Set 1 #

Patch Set 2 : fix docstring #

Total comments: 2

Patch Set 3 : review comments #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -21 lines)			Patch
M	dbus_service.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	omaha_request_params.h	View	1 2	5 chunks	+37 lines, -5 lines	0 comments	Download
M	omaha_request_params.cc	View	1 2	5 chunks	+66 lines, -10 lines	0 comments	Download
M	omaha_request_params_unittest.cc	View	1 2	3 chunks	+159 lines, -4 lines	0 comments	Download
M	update_engine_client.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ nit http://codereview.chromium.org/4103002/diff/3001/4003 File omaha_request_params.h (right): http://codereview.chromium.org/4103002/diff/3001/4003#newcode87 omaha_request_params.h:87: void SetBuildType(bool official); maybe SetBuildTypeOfficial(bool is_official) ...

10 years, 2 months ago (2010-10-25 23:27:02 UTC) #2

petkov

10 years, 2 months ago (2010-10-25 23:34:00 UTC) #3

Pushing...

http://codereview.chromium.org/4103002/diff/3001/4003
File omaha_request_params.h (right):

http://codereview.chromium.org/4103002/diff/3001/4003#newcode87
omaha_request_params.h:87: void SetBuildType(bool official);
On 2010/10/25 23:27:02, adlr wrote:
> maybe SetBuildTypeOfficial(bool is_official) would be a more readable name at
> the call sites?

Done.

Expand Messages | Collapse Messages