Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 4102013: Added option for including priority/milestone to cros_changelog. (Closed)

Created:
10 years, 1 month ago by diandersAtChromium
Modified:
9 years, 6 months ago
Reviewers:
davidjames, djmm
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Added option for including priority/milestone to cros_changelog. You can access this by passing: --tracker-user="user@chromium.org" --tracker-passfile="fileContainingPassword" ...to access anonymously, just set --tracker-user="" ...if you don't include the --tracker-user option, we won't try to fetch priority/milestone. To use this feature, you need the GData library. Until we get that put in hard-host-depends, the script will simply print instructions for installing GData if it detects that you don't have it. At the moment, I believe that logging in isn't giving you any extra access. Therefore, any bugs that don't allow anonymous access will not show their priority/milestone. I am working on figuring out what the problem is there. Change-Id: If388c20c43ee2fb0c1ab8f748ffea65e354eeb1e BUG=chromium-os:8205 TEST=Ran ./cros_changelog 0.9.104.0 --tracker-user="" and verified that some bugs got priority/milestone. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=48849e2

Patch Set 1 #

Patch Set 2 : Added proper tracker_access file. First was a symlink (oops!) #

Patch Set 3 : Fixed problems with logging in; enabled error printing by default now. #

Total comments: 7

Patch Set 4 : Fixes from David James code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -28 lines) Patch
M chromite/bin/cros_changelog View 1 2 3 8 chunks +143 lines, -28 lines 0 comments Download
A chromite/lib/tracker_access.py View 1 2 3 1 chunk +166 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
diandersAtChromium
Getting this submitted in, even though it seems to have trouble accessing protected bugs (even ...
10 years, 1 month ago (2010-10-29 18:01:13 UTC) #1
diandersAtChromium
Fixed login problems. Proving a username / password will now get you access. One note: ...
10 years, 1 month ago (2010-10-29 18:47:07 UTC) #2
davidjames
10 years, 1 month ago (2010-10-29 21:23:23 UTC) #3
LGTM w/nits

http://codereview.chromium.org/4102013/diff/5001/6001
File chromite/bin/cros_changelog (right):

http://codereview.chromium.org/4102013/diff/5001/6001#newcode113
chromite/bin/cros_changelog:113: info_str = ' (%s)' % (self.milestone)
No need for parens here. Just end with % self.milestone.

http://codereview.chromium.org/4102013/diff/5001/6001#newcode115
chromite/bin/cros_changelog:115: info_str = ' (P%s)' % (self.priority)
Same here.

http://codereview.chromium.org/4102013/diff/5001/6001#newcode290
chromite/bin/cros_changelog:290: options.tracker_pass =
open(options.tracker_passfile, "r")
Can you just open and read the file here, rather than passing in a file object?

http://codereview.chromium.org/4102013/diff/5001/6002
File chromite/lib/tracker_access.py (right):

http://codereview.chromium.org/4102013/diff/5001/6002#newcode38
chromite/lib/tracker_access.py:38: # Assume password is a file-like object and
read out the password.
Let's get rid of the whole condition and just always pass in the password as a
string.

http://codereview.chromium.org/4102013/diff/5001/6002#newcode127
chromite/lib/tracker_access.py:127: # If password was specified as a file, we'll
get a file path...
Please always pass in the password as a string. Easier :)

http://codereview.chromium.org/4102013/diff/5001/6002#newcode143
chromite/lib/tracker_access.py:143: if (len(args) >= 2) and (args[0] == "help")
and (args[1] in commands):
Too many parens. Remove the extra ones.

http://codereview.chromium.org/4102013/diff/5001/6002#newcode164
chromite/lib/tracker_access.py:164: if (len(sys.argv) <= 1) or (sys.argv[1] not
in commands):
Remove extra parens.

Powered by Google App Engine
This is Rietveld 408576698