Issue 41017: WebKit merge 41498:41530.

Issue 41017: WebKit merge 41498:41530. (Closed)

Created:
11 years, 9 months ago by eroman

Modified:
7 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

WebKit merge 41498:41530. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11312

Patch Set 2 : add tests_fixable.txt #

Total comments: 2

Patch Set 3 : address darin's comments #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	WEBKIT_MERGE_REVISION	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/build/WebCore/SConscript	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/build/WebCore/WebCore.vcproj	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	webkit/glue/editor_client_impl.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/searchable_form_data.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/glue/webframeloaderclient_impl.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/port/bindings/v8/v8_proxy.cpp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View	2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/webkit.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eroman

http://codereview.chromium.org/41017/diff/1/6 File webkit/glue/webframeloaderclient_impl.cc (right): http://codereview.chromium.org/41017/diff/1/6#newcode1222 Line 1222: // FIXME: setPreviousHistoryItem() no longer exists. http://crbug.com/8566 I ...

11 years, 9 months ago (2009-03-09 21:38:36 UTC) #1

darin (slow to review)

the setPreviousHistoryItem thing might be leftover cruft. if it can really be killed, then that's ...

11 years, 9 months ago (2009-03-09 23:03:37 UTC) #2

forgot to say:  otherwise LGTM

Expand Messages | Collapse Messages