Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: src/property.h

Issue 4100005: Version 2.5.2 (Closed)
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/profile-generator.cc ('k') | src/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/property.h
diff --git a/src/property.h b/src/property.h
index 01c58def3ee68152199091bc2e831aef2d7e51f5..4715a725f1a4a0e36ce02109ba02a3807e97987a 100644
--- a/src/property.h
+++ b/src/property.h
@@ -45,10 +45,12 @@ class Descriptor BASE_EMBEDDED {
return Smi::cast(value)->value();
}
- Object* KeyToSymbol() {
+ MUST_USE_RESULT MaybeObject* KeyToSymbol() {
if (!StringShape(key_).IsSymbol()) {
- Object* result = Heap::LookupSymbol(key_);
- if (result->IsFailure()) return result;
+ Object* result;
+ { MaybeObject* maybe_result = Heap::LookupSymbol(key_);
+ if (!maybe_result->ToObject(&result)) return maybe_result;
+ }
key_ = String::cast(result);
}
return key_;
« no previous file with comments | « src/profile-generator.cc ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698