Issue 4097004: Use g_strdup() instead of strdup().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4097004: Use g_strdup() instead of strdup(). (Closed)

Created:
10 years, 1 month ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr, Peng

Base URL:
http://git.chromium.org/git/update_engine.git

Visibility:
Public.

Description

Use g_strdup() instead of strdup(). The strings are freed in dbus-glib with g_free(), hence we should use g_strdup(). TEST=confirmed that update_engine worked as before BUG=chromium-os:8197 Change-Id: Idf07d1ded34b7f55ac78d16b74fabb5701038068 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d698231

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	dbus_service.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

satorux1

This is not a high priority change. I'll submit this once the R9 busy time ...

10 years, 1 month ago (2010-10-27 09:06:42 UTC) #1

LGTM -- thanks!

Expand Messages | Collapse Messages