Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 4096: Use open-vcdiff for sdch compression on the Mac (Closed)

Created:
12 years, 3 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use open-vcdiff for sdch compression on the Mac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2628

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12398 lines, -11941 lines) Patch
M build/all.xcodeproj/project.pbxproj View 1 8 chunks +43 lines, -2 lines 0 comments Download
M net/base/filter.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/base/sdch_filter_unitest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/base/test_completion_callback_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M net/net.xcodeproj/project.pbxproj View 1 2 16 chunks +55 lines, -0 lines 0 comments Download
M sdch/SConscript View 0 chunks +-1 lines, --1 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/AUTHORS View 1 chunk +2 lines, -2 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/COPYING View 1 chunk +202 lines, -202 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/ChangeLog View 1 chunk +6 lines, -6 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/INSTALL View 1 chunk +236 lines, -236 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/Makefile.am View 1 chunk +196 lines, -196 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/THANKS View 1 chunk +34 lines, -34 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/aclocal.m4 View 1 chunk +7269 lines, -7269 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/config.guess View 1 chunk +1466 lines, -1466 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/config.sub View 1 chunk +1579 lines, -1579 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/configure.ac View 1 chunk +51 lines, -51 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/m4/ac_have_attribute.m4 View 1 chunk +16 lines, -16 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/m4/acx_pthread.m4 View 1 chunk +363 lines, -363 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/missing View 1 chunk +360 lines, -360 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/changelog View 1 chunk +5 lines, -5 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/compat View 1 chunk +1 line, -1 line 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/control View 1 chunk +22 lines, -22 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/copyright View 1 chunk +20 lines, -20 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/deb/docs View 1 chunk +6 lines, -6 lines 0 comments Download
MM sdch/open_vcdiff/depot/opensource/open-vcdiff/packages/rpm/rpm.spec View 1 chunk +82 lines, -82 lines 0 comments Download
A sdch/sdch.xcodeproj/project.pbxproj View 1 chunk +249 lines, -0 lines 0 comments Download
A sdch/sdch.xcodeproj/sdch_prebuild.sh View 1 chunk +59 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj View 1 2 3 18 chunks +66 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
The project file is pretty straightforward and simple, especially now that we keep pre-build scripts ...
12 years, 3 months ago (2008-09-25 22:14:33 UTC) #1
pink (ping after 24hrs)
LGTM
12 years, 2 months ago (2008-09-26 13:05:46 UTC) #2
Amanda Walker
12 years, 2 months ago (2008-09-26 13:08:19 UTC) #3
LGTM. looks like it should work for linux as well.

Powered by Google App Engine
This is Rietveld 408576698