Issue 4094001: AU: Provide a D-Bus API for changing the update track.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4094001: AU: Provide a D-Bus API for changing the update track. (Closed)

Created:
10 years, 2 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr, satorux1

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Provide a D-Bus API for changing the update track. The method is SetTrack(string). It doesn't do anything right now but hopefully this CL will enable work on libcros. BUG=8104 TEST=unit tests; tested on device through update_engine_client. Change-Id: I6941fe3d04165d85c4612e3a01939d02c02014f9 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8daa324

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -1 line)			Patch
M	dbus_service.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	dbus_service.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	update_engine.xml	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	update_engine_client.cc	View	1	4 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ nit http://codereview.chromium.org/4094001/diff/1/5 File update_engine_client.cc (right): http://codereview.chromium.org/4094001/diff/1/5#newcode192 update_engine_client.cc:192: LOG(INFO) << "Track permanently set to: ...

10 years, 2 months ago (2010-10-25 20:20:45 UTC) #2

petkov

10 years, 2 months ago (2010-10-25 20:24:22 UTC) #3

http://codereview.chromium.org/4094001/diff/1/5
File update_engine_client.cc (right):

http://codereview.chromium.org/4094001/diff/1/5#newcode192
update_engine_client.cc:192: LOG(INFO) << "Track permanently set to: " << track;
On 2010/10/25 20:20:45, adlr wrote:
> maybe change this string to indicate that it hasn't actually done anything yet

Done. Added a TODO: to the string. Also on the daemon side.

Expand Messages | Collapse Messages