Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: net/socket/ssl_client_socket_openssl.cc

Issue 4091005: Remove SSL 2.0 support. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Sync with ToT Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket/ssl_client_socket_nss.cc ('k') | net/socket/ssl_client_socket_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // OpenSSL binding for SSLClientSocket. The class layout and general principle 5 // OpenSSL binding for SSLClientSocket. The class layout and general principle
6 // of operation is derived from SSLClientSocketNSS. 6 // of operation is derived from SSLClientSocketNSS.
7 7
8 #include "net/socket/ssl_client_socket_openssl.h" 8 #include "net/socket/ssl_client_socket_openssl.h"
9 9
10 #include <openssl/ssl.h> 10 #include <openssl/ssl.h>
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 260
261 SSL_set_bio(ssl_, ssl_bio, ssl_bio); 261 SSL_set_bio(ssl_, ssl_bio, ssl_bio);
262 262
263 #define SET_SSL_CONFIG_OPTION(option, value) \ 263 #define SET_SSL_CONFIG_OPTION(option, value) \
264 (((value) ? set_mask : clear_mask) |= (option)) 264 (((value) ? set_mask : clear_mask) |= (option))
265 265
266 // OpenSSL defaults some options to on, others to off. To avoid ambiguity, 266 // OpenSSL defaults some options to on, others to off. To avoid ambiguity,
267 // set everything we care about to an absolute value. 267 // set everything we care about to an absolute value.
268 long set_mask = 0; 268 long set_mask = 0;
269 long clear_mask = 0; 269 long clear_mask = 0;
270 SET_SSL_CONFIG_OPTION(SSL_OP_NO_SSLv2, !ssl_config_.ssl2_enabled); 270 SET_SSL_CONFIG_OPTION(SSL_OP_NO_SSLv2, true);
271 SET_SSL_CONFIG_OPTION(SSL_OP_NO_SSLv3, !ssl_config_.ssl3_enabled); 271 SET_SSL_CONFIG_OPTION(SSL_OP_NO_SSLv3, !ssl_config_.ssl3_enabled);
272 SET_SSL_CONFIG_OPTION(SSL_OP_NO_TLSv1, !ssl_config_.tls1_enabled); 272 SET_SSL_CONFIG_OPTION(SSL_OP_NO_TLSv1, !ssl_config_.tls1_enabled);
273 273
274 // TODO(joth): Set this conditionally, see http://crbug.com/55410 274 // TODO(joth): Set this conditionally, see http://crbug.com/55410
275 SET_SSL_CONFIG_OPTION(SSL_OP_LEGACY_SERVER_CONNECT, true); 275 SET_SSL_CONFIG_OPTION(SSL_OP_LEGACY_SERVER_CONNECT, true);
276 276
277 // Make sure we haven't got any intersection in the set & clear options. 277 // Make sure we haven't got any intersection in the set & clear options.
278 DCHECK_EQ(0, set_mask & clear_mask); 278 DCHECK_EQ(0, set_mask & clear_mask);
279 279
280 SSL_set_options(ssl_, set_mask); 280 SSL_set_options(ssl_, set_mask);
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
865 int rv = SSL_write(ssl_, user_write_buf_->data(), user_write_buf_len_); 865 int rv = SSL_write(ssl_, user_write_buf_->data(), user_write_buf_len_);
866 866
867 if (rv >= 0) 867 if (rv >= 0)
868 return rv; 868 return rv;
869 869
870 int err = SSL_get_error(ssl_, rv); 870 int err = SSL_get_error(ssl_, rv);
871 return MapOpenSSLError(err); 871 return MapOpenSSLError(err);
872 } 872 }
873 873
874 } // namespace net 874 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/ssl_client_socket_nss.cc ('k') | net/socket/ssl_client_socket_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698