Fix bug with context menus in incognito mode.

Fix bug with context menus in incognito mode.

If an extension uses "spanning" mode, the context menu items are shared
between profiles. If an extension uses "split" mode, the items are separate
per profile. In either case, they only appear in incognito if the extension is
enabled in incognito.

Also fixed a minor bug, so that tabs.create now can open extension URLs in
incognito if the extension uses split mode.

BUG=61147
TEST=see bug for repro steps; context menu items should work in incognito mode

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64812

[asargent_no_longer_on_chrome, 2010-11-01 17:33:31]

Looks good in general. I'd like to see at least one browser test though;
ExtensionContextMenuBrowserTest.Simple would probably be a good model to
emulate.

[asargent_no_longer_on_chrome, 2010-11-01 17:33:56]

http://codereview.chromium.org/4090011/diff/2001/3004
File chrome/browser/extensions/extension_menu_manager.cc (right):

http://codereview.chromium.org/4090011/diff/2001/3004#newcode488
chrome/browser/extensions/extension_menu_manager.cc:488: extension_id ==
other.extension_id &&
style nit: should the two lines beginning with "extension_id" and "uid" here be
indented to match up with "profile" on the line above?

http://codereview.chromium.org/4090011/diff/2001/3005
File chrome/browser/extensions/extension_menu_manager.h (right):

http://codereview.chromium.org/4090011/diff/2001/3005#newcode37
chrome/browser/extensions/extension_menu_manager.h:37: // extension.
nit: update or remove the comment here.

http://codereview.chromium.org/4090011/diff/2001/3005#newcode47
chrome/browser/extensions/extension_menu_manager.h:47: Profile* profile;
Did you consider just using a boolean for indicating regular vs. incognito,
instead of storing a pointer to the profile? It might not make much difference,
but could conceivably reduce coupling a bit. Not a big deal either way.

[Matt Perry, 2010-11-01 19:34:01]

I'll work on the browser test now. Thanks for the pointer to the similar test -
I originally looked at ExtensionApiTest.ContextMenus and it didn't look like a
good match. This one looks much closer to what I need.

http://codereview.chromium.org/4090011/diff/2001/3004
File chrome/browser/extensions/extension_menu_manager.cc (right):

http://codereview.chromium.org/4090011/diff/2001/3004#newcode488
chrome/browser/extensions/extension_menu_manager.cc:488: extension_id ==
other.extension_id &&
On 2010/11/01 17:33:56, Antony Sargent wrote:
> style nit: should the two lines beginning with "extension_id" and "uid" here
be
> indented to match up with "profile" on the line above?

Done.

http://codereview.chromium.org/4090011/diff/2001/3005
File chrome/browser/extensions/extension_menu_manager.h (right):

http://codereview.chromium.org/4090011/diff/2001/3005#newcode37
chrome/browser/extensions/extension_menu_manager.h:37: // extension.
On 2010/11/01 17:33:56, Antony Sargent wrote:
> nit: update or remove the comment here.

Done.

http://codereview.chromium.org/4090011/diff/2001/3005#newcode47
chrome/browser/extensions/extension_menu_manager.h:47: Profile* profile;
On 2010/11/01 17:33:56, Antony Sargent wrote:
> Did you consider just using a boolean for indicating regular vs. incognito,
> instead of storing a pointer to the profile? It might not make much
difference,
> but could conceivably reduce coupling a bit. Not a big deal either way. 

I hadn't thought of that. It sounds reasonable, but I don't mind using Profile
here either. It's what I've done elsewhere for incognito guarding too.

[Matt Perry, 2010-11-02 01:20:11]

OK, uploaded with a browser test

[asargent_no_longer_on_chrome, 2010-11-02 17:44:42]

lgtm