Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 4090003: Allow forcing the use of a simulator from the build script... (Closed)

Created:
10 years, 1 month ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Allow forcing the use of a simulator from the build script independently of the host architecture. Fix build issue for the mips simulator. The mips simulator does not currently work, but at least this change does not make it worse. Committed: http://code.google.com/p/v8/source/detail?r=5701

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M src/globals.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/top.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/v8.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
10 years, 1 month ago (2010-10-26 06:25:29 UTC) #1
Kasper Lund
10 years, 1 month ago (2010-10-26 08:09:19 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698