Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 4089006: Specify client version 2 when creating EGL contexts.... (Closed)

Created:
10 years, 1 month ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
greggman
CC:
chromium-reviews, arcadyg
Visibility:
Public.

Description

Specify client version 2 when creating EGL contexts. It was doing this already for SecondaryEGLContext but not for NativeViewEGLContext, which made it default to EGL version 1 on non-ANGLE EGL implementations. I also fixed ANGLE upstream in r468 so it fails to create a context unless version 2 is explicitly requested. TEST=try BUG=53823 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M app/gfx/gl/gl_context_egl.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apatrick_chromium
10 years, 1 month ago (2010-10-27 18:26:28 UTC) #1
greggman
10 years, 1 month ago (2010-10-27 19:28:43 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698