Issue 4088007: Add direct flush calls to stderr / stdout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4088007: Add direct flush calls to stderr / stdout. (Closed)

Created:
10 years, 1 month ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Add direct flush calls to stderr / stdout. Change-Id: I272661e276f4968d464706c802e24a0600b9af46 BUG=8393 TEST=N/A Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cf51905

Patch Set 1 #

Patch Set 2 : Fix comments #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	generate_test_report.py	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 1 month ago (2010-10-29 16:12:57 UTC) #2

LGTM - thanks!  Hopefully that does it...

On Fri, Oct 29, 2010 at 9:11 AM,  <sosa@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Add direct flush calls to stderr / stdout.
>
> Change-Id: I272661e276f4968d464706c802e24a0600b9af46
>
> BUG=
> TEST=N/A
>
> Please review this at http://codereview.chromium.org/4088007/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git
>
> Affected files:
>  M generate_test_report.py
>
>
> Index: generate_test_report.py
> diff --git a/generate_test_report.py b/generate_test_report.py
> index
>
f152a61a7468d34e09012bb58f44faa4aed3d8bf..345f2992d1c5bf38569c38434f72da51e4618694
> 100755
> --- a/generate_test_report.py
> +++ b/generate_test_report.py
> @@ -234,6 +234,10 @@ class ReportGenerator(object):
>           except:
>             print 'Could not open %s' % path
>
> +      # Sometimes that builders exit before these buffers are flushed.
> +      sys.stderr.flush()
> +      sys.stdout.flush()
> +
>   def Run(self):
>     """Runs report generation."""
>     self._CollectResults()
>
>
>

Expand Messages | Collapse Messages