Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 4088: Move a bunch of stuff out of WebContents. I removed a bunch of render view ho... (Closed)

Created:
12 years, 3 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move a bunch of stuff out of WebContents. I removed a bunch of render view host pass-throughs and just made the callers call the render view host directly. I don't think we're trying to isolate the layers to this degree, and WebContents is so big these just added noise. I removed the RenderViewHost->WebContents->SavePackage pass-through by using a delegate that the SavePackage implements (like we already do for find in page). I also noticed some file upload stuff wasn't used at all and removed it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2612

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -373 lines) Patch
M chrome/browser/automation/automation_provider.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_host.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/download/save_file_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_package.h View 6 chunks +37 lines, -33 lines 0 comments Download
M chrome/browser/download/save_package.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/jsmessage_box_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/render_view_context_menu_controller.cc View 3 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/render_view_host.h View 1 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/render_view_host.cc View 1 4 chunks +11 lines, -23 lines 0 comments Download
M chrome/browser/render_view_host_delegate.h View 1 2 chunks +26 lines, -20 lines 0 comments Download
M chrome/browser/ssl_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/web_contents.h View 1 7 chunks +9 lines, -99 lines 0 comments Download
M chrome/browser/web_contents.cc View 9 chunks +5 lines, -154 lines 1 comment Download
M chrome/browser/web_drop_target.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
12 years, 3 months ago (2008-09-25 17:29:22 UTC) #1
huanr
12 years, 3 months ago (2008-09-25 18:01:39 UTC) #2
lgtm

http://codereview.chromium.org/4088/diff/219/32
File chrome/browser/web_contents.cc (left):

http://codereview.chromium.org/4088/diff/219/32#oldcode285
Line 285: render_view_host()->FirePageBeforeUnload();
what is the reason to keep this function in WebContents?

Powered by Google App Engine
This is Rietveld 408576698