Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chrome/test/ui/npapi_uitest.cc

Issue 4087009: Update a bunch of FLAKY_ tests to match current reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/startup/startup_test.cc ('k') | chrome_frame/test/test_with_web_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/npapi_uitest.cc
diff --git a/chrome/test/ui/npapi_uitest.cc b/chrome/test/ui/npapi_uitest.cc
index be46943b06a39bc2ca440900fe954120505f7191..0fc336d9c31af71b50a14c85bd84bf11fa3f606e 100644
--- a/chrome/test/ui/npapi_uitest.cc
+++ b/chrome/test/ui/npapi_uitest.cc
@@ -45,9 +45,7 @@ TEST_F(NPAPITesterBase, Arguments) {
}
// Test invoking many plugins within a single page.
-// Test still flaky under valgrind
-// http://crbug.com/28372, http://crbug.com/45561
-TEST_F(NPAPITesterBase, FLAKY_ManyPlugins) {
+TEST_F(NPAPITesterBase, ManyPlugins) {
const FilePath test_case(FILE_PATH_LITERAL("many_plugins.html"));
GURL url(ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case));
ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
@@ -336,8 +334,7 @@ TEST_F(NPAPITesterBase, EnsureScriptingWorksInDestroy) {
// This test uses a Windows Event to signal to the plugin that it should crash
// on NP_Initialize.
-// This is flaky. http://crbug.com/32048
-TEST_F(NPAPITesterBase, FLAKY_NoHangIfInitCrashes) {
+TEST_F(NPAPITesterBase, NoHangIfInitCrashes) {
if (UITest::in_process_renderer())
return;
« no previous file with comments | « chrome/test/startup/startup_test.cc ('k') | chrome_frame/test/test_with_web_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698