base/debug/stack_trace_unittest.cc - Issue 4087009: Update a bunch of FLAKY_ tests to match current reality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/stack_trace_unittest.cc

Issue 4087009: Update a bunch of FLAKY_ tests to match current reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/stack_trace_unittest.cc

diff --git a/base/debug/stack_trace_unittest.cc b/base/debug/stack_trace_unittest.cc

index e8e1e19f2ac2864058fb73a6cbd11d467285a3e4..ce5f3136eb1d99ba2f38f3b2cd403bfc05d41a73 100644

--- a/base/debug/stack_trace_unittest.cc

+++ b/base/debug/stack_trace_unittest.cc

@@ -14,8 +14,13 @@ namespace debug {

// Note: On Linux, this test currently only fully works on Debug builds.

// See comments in the #ifdef soup if you intend to change this.

-// Flaky, crbug.com/32070.

-TEST(StackTrace, FLAKY_OutputToStream) {

+#if defined(OS_WIN)

+// Always fails on Windows: crbug.com/32070

+#define MAYBE_OutputToStream FAILS_OutputToStream

+#else

+#define MAYBE_OutputToStream OutputToStream

+#endif

+TEST(StackTrace, MAYBE_OutputToStream) {

StackTrace trace;

// Dump the trace into a string.

« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc » ('j') | no next file with comments »