Issue 408: Fix an out of band read when parsing a URL component of just "%". The...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 408: Fix an out of band read when parsing a URL component of just "%". The... (Closed)

Created:
12 years, 3 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
brettw, M-A Ruel

CC:
chromium-reviews_googlegroups.com, sky

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix an out of band read when parsing a URL component of just "%". The calculation of max_digit_index is unsigned, and was underflowing when max was less than 2. BUG=122 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1677

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	net/base/escape.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	net/base/escape_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Dean McNamee

12 years, 3 months ago (2008-09-03 10:45:15 UTC) #1

I just fixed the single case, and I'm not sure it's 100%.  This is actually
sky's code, but reviewing to brettw.