- Added a map cache for literal objects. This will...

- Added a map cache for literal objects. This will
  canonicalize maps for object literals. JSON objects
  with the same set of properties names will then
  share the same map.
  This reduces the amount of generated code associated 
  with object literals.
- Added a flag canonicalize_object_literal_maps.
  (default true)
- Changed the format of a function's literal array.
  Only the global context is now stored in the literal prefix.


Committed: http://code.google.com/p/v8/source/detail?r=371

[Mads Ager (chromium), 2008-09-25 07:23:18]

LGTM!

http://codereview.chromium.org/4078/diff/1/12
File src/factory.cc (right):

http://codereview.chromium.org/4078/diff/1/12#newcode769
Line 769: Handle<FixedArray> keys,
Indentation slightly off here.

http://codereview.chromium.org/4078/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/4078/diff/1/2#newcode5664
Line 5664: // SymbolsKey used for HashTable were key is array of symbols.
were -> where

http://codereview.chromium.org/4078/diff/1/4
File src/runtime.cc (right):

http://codereview.chromium.org/4078/diff/1/4#newcode101
Line 101: Handle<FixedArray> constant_properties,
Indentation slightly off here.

http://codereview.chromium.org/4078/diff/1/4#newcode107
Line 107: while ((number_of_symbol_keys < number_of_properties)
How about: 

    while ((number_of_symbol_keys == number_of_properties) &&
           (constant_properties->get(number_of_symbol_keys*2)->IsSymbol())) {

Doesn't that fit in 80 columns?

http://codereview.chromium.org/4078/diff/1/4#newcode117
Line 117: // Create the fixed array with the key.
Indent two more spaces?