bin/cros_run_wifi_tests.sh - Issue 4069001: Complain (and more importantly don't blindly run) if AP or Client IP is unset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bin/cros_run_wifi_tests.sh

Issue 4069001: Complain (and more importantly don't blindly run) if AP or Client IP is unset (Closed) Base URL: ssh://gitrw.chromium.org/crosutils.git

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: bin/cros_run_wifi_tests.sh

diff --git a/bin/cros_run_wifi_tests.sh b/bin/cros_run_wifi_tests.sh

index f948a4ef4ca5d4b2ec345c59fcdab28d3e3f9bcc..babb3d1b02ec0747be062aee2a0daa29db359e63 100755

--- a/bin/cros_run_wifi_tests.sh

+++ b/bin/cros_run_wifi_tests.sh

@@ -123,6 +123,10 @@ while read line; do

set $line

if [ "${FLAGS_cell}" = "$cell_no" -o "${FLAGS_client}" = "$1" -o \

"${FLAGS_client}" = "$4" ] ; then

+ if [ "$5" = "0.0.0.0" -o "$4" = "0.0.0.0" ]; then

+ # Error -- these should never be zeroes

+ break

+ fi

echo "$4"

echo "router_addr=$5"

if [ "$6" != "0.0.0.0" ] ; then

« no previous file with comments | « no previous file | no next file » | no next file with comments »