Archive test results and image after running vm suite.

Archive test results and image after running vm suite.

Change-Id: Ic6d4a79a7ab58b8043805a6b826f251faa9f3a6c

BUG=
TEST=Running now (adding unit tests as well)

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7e493cb

[sosa, 2010-10-22 20:08:47]

Current change, adding tests.  Sending out for review to see if approach is good

[kmixter1, 2010-10-22 20:20:28]

LGTM

http://codereview.chromium.org/4062003/diff/2001/3001
File bin/cbuildbot.py (right):

http://codereview.chromium.org/4062003/diff/2001/3001#newcode394
bin/cbuildbot.py:394: if len_entries >= ARCHIVE_COUNT:
This only removes one towards getting back down to ARCHIVE_COUNT.  Assuming this
code always is what generates entries it should remain stable, but may be worth
a comment.

http://codereview.chromium.org/4062003/diff/2001/3001#newcode397
bin/cbuildbot.py:397: Info('Removing oldest arhive dir %s' % oldest_dir)
archive

http://codereview.chromium.org/4062003/diff/2001/3001#newcode403
bin/cbuildbot.py:403: shutil.copy_tree(results_path, archive_target)
Keeping them untarred for easier browsing is definitely good.

http://codereview.chromium.org/4062003/diff/2001/3001#newcode408
bin/cbuildbot.py:408: RunCommand(['gzip', image_path])
Can you gzip it to the destination instead of gzipping and then copying?

[sosa, 2010-10-22 20:58:39]

Addressed comments and switching to using heapq.nsmallest which returns an array
of the n smallest.

Also added unit test.

http://codereview.chromium.org/4062003/diff/2001/3001
File bin/cbuildbot.py (right):

http://codereview.chromium.org/4062003/diff/2001/3001#newcode397
bin/cbuildbot.py:397: Info('Removing oldest arhive dir %s' % oldest_dir)
On 2010/10/22 20:20:29, kmixter1 wrote:
> archive

Done.

http://codereview.chromium.org/4062003/diff/2001/3001#newcode408
bin/cbuildbot.py:408: RunCommand(['gzip', image_path])
On 2010/10/22 20:20:29, kmixter1 wrote:
> Can you gzip it to the destination instead of gzipping and then copying?

Done.

[sosa, 2010-10-22 21:04:44]

Oh i meant to say if you could PTAL

[kmixter1, 2010-10-22 21:30:02]

LGTM

http://codereview.chromium.org/4062003/diff/10001/11003
File bin/cros_run_vm_test (right):

http://codereview.chromium.org/4062003/diff/10001/11003#newcode20
bin/cros_run_vm_test:20: DEFINE_string results_dir_root "" "alternate root
results directory"
may want to say it must be in /tmp, but not big deal.