Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: chrome/browser/browser_navigator.h

Issue 4055004: Change window opening behavior for HtmlDialogTabContentsDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased from trunk and fixed comments in HtmlDialogTabContentsDelegate Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_navigator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_navigator.h
diff --git a/chrome/browser/browser_navigator.h b/chrome/browser/browser_navigator.h
index c770d8aae2973b7eae1c568b008f409c2f40fbf0..9d099d89cfe780e7c489ad9b26c658c8a8eedbae 100644
--- a/chrome/browser/browser_navigator.h
+++ b/chrome/browser/browser_navigator.h
@@ -118,8 +118,8 @@ struct NavigateParams {
// [in] Specifies a Browser object where the navigation could occur or the
// tab could be added. Navigate() is not obliged to use this Browser if
- // it is not compatible with the operation being performed. Cannot be
- // NULL since Navigate() uses this Browser's Profile.
+ // it is not compatible with the operation being performed. If NULL,
+ // |profile| should be specified to find or create a matching Browser.
// [out] Specifies the Browser object where the navigation occurred or the
// tab was added. Guaranteed non-NULL unless the disposition did not
// require a navigation, in which case this is set to NULL
@@ -130,6 +130,10 @@ struct NavigateParams {
// objects are deleted when the user closes a visible browser window).
Browser* browser;
+ // If |browser| == NULL, specifies a Profile to use when finding or
+ // creating a Browser.
+ Profile* profile;
+
private:
NavigateParams();
};
@@ -140,4 +144,3 @@ void Navigate(NavigateParams* params);
} // namespace browser
#endif // CHROME_BROWSER_BROWSER_NAVIGATOR_H_
-
« no previous file with comments | « no previous file | chrome/browser/browser_navigator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698