chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h - Issue 4055004: Change window opening behavior for HtmlDialogTabContentsDelegate.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h

Issue 4055004: Change window opening behavior for HtmlDialogTabContentsDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased from trunk and fixed comments in HtmlDialogTabContentsDelegate Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/browser_navigator_browsertest.cc ('k') | chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_DOM_UI_HTML_DIALOG_TAB_CONTENTS_DELEGATE_H_	5 #ifndef CHROME_BROWSER_DOM_UI_HTML_DIALOG_TAB_CONTENTS_DELEGATE_H_

6 #define CHROME_BROWSER_DOM_UI_HTML_DIALOG_TAB_CONTENTS_DELEGATE_H_	6 #define CHROME_BROWSER_DOM_UI_HTML_DIALOG_TAB_CONTENTS_DELEGATE_H_

7 #pragma once	7 #pragma once

8	8

9 #include "chrome/browser/tab_contents/tab_contents_delegate.h"	9 #include "chrome/browser/tab_contents/tab_contents_delegate.h"

10	10

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 virtual void DeactivateContents(TabContents* contents);	51 virtual void DeactivateContents(TabContents* contents);

52 virtual void LoadingStateChanged(TabContents* source);	52 virtual void LoadingStateChanged(TabContents* source);

53 virtual void CloseContents(TabContents* source);	53 virtual void CloseContents(TabContents* source);

54 virtual bool IsPopup(const TabContents* source) const;	54 virtual bool IsPopup(const TabContents* source) const;

55 virtual void URLStarredChanged(TabContents* source, bool starred);	55 virtual void URLStarredChanged(TabContents* source, bool starred);

56 virtual void UpdateTargetURL(TabContents* source, const GURL& url);	56 virtual void UpdateTargetURL(TabContents* source, const GURL& url);

57 virtual bool ShouldAddNavigationToHistory(	57 virtual bool ShouldAddNavigationToHistory(

58 const history::HistoryAddPageArgs& add_page_args,	58 const history::HistoryAddPageArgs& add_page_args,

59 NavigationType::Type navigation_type);	59 NavigationType::Type navigation_type);

60	60

61 protected:

62 // Overridden only for testing.

63 virtual Browser* CreateBrowser();

64

65 private:	61 private:

66 Profile* profile_; // Weak pointer. Always an original profile.	62 Profile* profile_; // Weak pointer. Always an original profile.

67 };	63 };

68	64

69 #endif // CHROME_BROWSER_DOM_UI_HTML_DIALOG_TAB_CONTENTS_DELEGATE_H_	65 #endif // CHROME_BROWSER_DOM_UI_HTML_DIALOG_TAB_CONTENTS_DELEGATE_H_

70

OLD	NEW