Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 4054004: Move all Valgrind/TSan/Dr.Memory gtest exclude files to tools/valgrind/gtest_... (Closed)

Created:
10 years, 2 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Alexander Potapenko, brettw-cc_chromium.org, Timur Iskhodzhanov, cbentzel+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Move all Valgrind/TSan/Dr.Memory gtest exclude files to tools/valgrind/gtest_exclude If I receive an LGTM, I'll land this patch (with updated .txt files of course) during the weekend in the Europe afternoon to minimize possible damages. Then I'll update all the docs accordingly For the record, I got the list of the files by doing find . | grep -v "\.svn" | grep "valgrind.*gtest" | sed "s/\.gtest.*$//" | \ sed "s/\/[a-z_]\+$//" | sort | uniq | tee list_dirs And then for F in `cat list_dirs`; do svn mv $F/*.txt tools/valgrind/gtest_exclude/; done TEST=ran a few tests locally under Valgrind and TSan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -728 lines) Patch
A base/data/valgrind/DIRECTORY_MOVED View 1 chunk +4 lines, -0 lines 0 comments Download
D base/data/valgrind/base_unittests.gtest.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D base/data/valgrind/base_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D base/data/valgrind/base_unittests.gtest-tsan.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D base/data/valgrind/base_unittests.gtest-tsan_mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D base/data/valgrind/base_unittests.gtest-tsan_win32.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D base/data/valgrind/base_unittests.gtest_mac.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D base/data/valgrind/base_unittests.gtest_win32.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D base/data/valgrind/base_unittests.gtest_wine.txt View 1 chunk +0 lines, -96 lines 0 comments Download
A chrome/test/data/valgrind/DIRECTORY_MOVED View 1 chunk +4 lines, -0 lines 0 comments Download
D chrome/test/data/valgrind/app_unittests.gtest-tsan.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/valgrind/media_unittests.gtest.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/valgrind/media_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/valgrind/remoting_unittests.gtest-tsan_win32.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/valgrind/ui_tests.gtest.txt View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/test/data/valgrind/ui_tests.gtest-tsan.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/valgrind/ui_tests.gtest-tsan_mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/valgrind/ui_tests.gtest_linux.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/valgrind/ui_tests.gtest_mac.txt View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/test/data/valgrind/unit_tests.gtest.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/valgrind/unit_tests.gtest-tsan.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/valgrind/unit_tests.gtest-tsan_mac.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/valgrind/unit_tests.gtest_linux.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/valgrind/unit_tests.gtest_mac.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/valgrind/unit_tests.gtest_wine.txt View 1 chunk +0 lines, -85 lines 0 comments Download
A ipc/data/valgrind/DIRECTORY_MOVED View 1 chunk +4 lines, -0 lines 0 comments Download
D ipc/data/valgrind/ipc_tests.gtest.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D ipc/data/valgrind/ipc_tests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A net/data/valgrind/DIRECTORY_MOVED View 1 chunk +4 lines, -0 lines 0 comments Download
D net/data/valgrind/net_unittests.gtest.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D net/data/valgrind/net_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D net/data/valgrind/net_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D net/data/valgrind/net_unittests.gtest-tsan.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D net/data/valgrind/net_unittests.gtest-tsan_mac.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D net/data/valgrind/net_unittests.gtest-tsan_win32.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D net/data/valgrind/net_unittests.gtest_linux.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D net/data/valgrind/net_unittests.gtest_mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D net/data/valgrind/net_unittests.gtest_wine.txt View 1 chunk +0 lines, -49 lines 0 comments Download
D net/data/valgrind/suppressions.txt View 1 chunk +0 lines, -39 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 3 chunks +45 lines, -54 lines 0 comments Download
A + tools/valgrind/gtest_exclude/app_unittests.gtest-tsan.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/base_unittests.gtest.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/base_unittests.gtest-drmemory_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/base_unittests.gtest-tsan.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/base_unittests.gtest-tsan_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/base_unittests.gtest-tsan_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/base_unittests.gtest_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/base_unittests.gtest_wine.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/ipc_tests.gtest.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/ipc_tests.gtest-drmemory_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/media_unittests.gtest.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/media_unittests.gtest-drmemory_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/media_unittests.gtest-tsan_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/media_unittests.gtest_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/net_unittests.gtest.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/net_unittests.gtest-memcheck.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/net_unittests.gtest-tsan.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/net_unittests.gtest_linux.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/net_unittests.gtest_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/net_unittests.gtest_wine.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/remoting_unittests.gtest-tsan_win32.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/suppressions.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/sync_unit_tests.gtest-tsan.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/test_shell_tests.gtest.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/ui_tests.gtest.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/ui_tests.gtest-tsan.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/ui_tests.gtest-tsan_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/ui_tests.gtest_linux.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/ui_tests.gtest_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/unit_tests.gtest.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/unit_tests.gtest-tsan.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/unit_tests.gtest-tsan_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/valgrind/gtest_exclude/unit_tests.gtest_wine.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/data/valgrind/DIRECTORY_MOVED View 1 chunk +4 lines, -0 lines 0 comments Download
D webkit/data/valgrind/test_shell_tests.gtest.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
Hi Lei, Can you please take a look at the ./tools/valgrind/chrome_tests.py diff? As I wrote ...
10 years, 2 months ago (2010-10-22 16:56:26 UTC) #1
Lei Zhang
10 years, 2 months ago (2010-10-22 18:49:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698