Issue 405023: Small cleanups:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405023: Small cleanups:... (Closed)

Created:
11 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Small cleanups: * SplitUrlAndTitle() can't fail, so it doesn't need to return a bool. * assign() can do substrings in one shot * Half the code used "*str =" and half "str->assign()", often right next to each other; pick one for consistency * No need to calculate array sizes when we're the ones declaring them * Use early return in a few places BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32414

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -55 lines)			Patch
	M	app/clipboard/clipboard_util_win.cc	View	1	6 chunks	+41 lines, -55 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages