Issue 405012: Mark fast/dom/Geolocation as DEFER SKIP since we don't implement it yet....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405012: Mark fast/dom/Geolocation as DEFER SKIP since we don't implement it yet.... (Closed)

Created:
11 years, 1 month ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Mark fast/dom/Geolocation as DEFER SKIP since we don't implement it yet. R=dglazkov@chromium.org BUG=11246 TEST=LayoutTests/fast/dom/Geolocation

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dglazkov

LGTM, except: http://codereview.chromium.org/405012/diff/1/2 File webkit/tools/layout_tests/test_expectations.txt (right): http://codereview.chromium.org/405012/diff/1/2#newcode692 Line 692: //BUG24192 SKIP : chrome/http/mime = PASS ...

11 years, 1 month ago (2009-11-18 03:11:49 UTC) #2

Dirk Pranke

11 years, 1 month ago (2009-11-18 03:25:33 UTC) #3

http://codereview.chromium.org/405012/diff/1/2
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/405012/diff/1/2#newcode692
Line 692: //BUG24192 SKIP : chrome/http/mime = PASS
On 2009/11/18 03:11:49, Dimitri Glazkov wrote:
> Did you mean to leave this in?

er, no.

Expand Messages | Collapse Messages

Issue 405012: Mark fast/dom/Geolocation as DEFER SKIP since we don't implement it yet.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages