Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 4044003: Clean up definitions in simulator. ... (Closed)

Created:
10 years, 2 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Clean up definitions in simulator. Clean up the definition of USE_SIMULATOR and its uses. Committed: http://code.google.com/p/v8/source/detail?r=5700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -57 lines) Patch
M SConstruct View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm/cpu-arm.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/arm/simulator-arm.h View 4 chunks +36 lines, -30 lines 0 comments Download
M src/arm/simulator-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/simulator-ia32.h View 2 chunks +13 lines, -8 lines 0 comments Download
M src/top.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/top.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/simulator-x64.h View 2 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
10 years, 2 months ago (2010-10-25 16:35:54 UTC) #1
fschneider
10 years, 2 months ago (2010-10-25 16:40:23 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698