Issue 4042004: AU: When applying delta locally, get source checksums

Issue 4042004: AU: When applying delta locally, get source checksums (Closed)

Created:
10 years, 2 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://git.chromium.org/git/update_engine.git

Visibility:
Public.

Description

AU: When applying delta locally, get source checksums When applying a delta on the host, we need to calculate the original checksums for the rootfs/kernel for the delta performer. This CL does that. Also: - Log old/new checksums in performer - Add base64 encode function to OmahaHashCalculator BUG=8062 TEST=unittests; applied delta on host Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=89f17be

Patch Set 1 #

Total comments: 8

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -14 lines)			Patch
M	delta_diff_generator.h	View	1 chunk	+4 lines, -0 lines	2 comments	Download
M	delta_performer.cc	View	2 chunks	+25 lines, -0 lines	2 comments	Download
M	generate_delta_main.cc	View	1 chunk	+15 lines, -0 lines	2 comments	Download
M	omaha_hash_calculator.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
	omaha_hash_calculator.cc	View	3 chunks	+21 lines, -14 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM w/ a few style nits. Sorry for breaking this. http://codereview.chromium.org/4042004/diff/1/2 File delta_diff_generator.h (right): http://codereview.chromium.org/4042004/diff/1/2#newcode223 ...

10 years, 2 months ago (2010-10-22 20:15:16 UTC) #2

adlr

10 years, 2 months ago (2010-10-22 20:40:18 UTC) #3

fixed; pushed

http://codereview.chromium.org/4042004/diff/1/2
File delta_diff_generator.h (right):

http://codereview.chromium.org/4042004/diff/1/2#newcode223
delta_diff_generator.h:223: bool InitializePartitionInfo(bool is_kernel,
On 2010/10/22 20:15:16, petkov wrote:
> Ah, I should have made this a static member of DeltaDiffGenerator. Up to you
if
> you want to fix.
> 

Done.

http://codereview.chromium.org/4042004/diff/1/3
File delta_performer.cc (right):

http://codereview.chromium.org/4042004/diff/1/3#newcode180
delta_performer.cc:180: void LogPartitionInfo(const DeltaArchiveManifest&
manifest) {
On 2010/10/22 20:15:16, petkov wrote:
> add blank line before
> 

Done.

http://codereview.chromium.org/4042004/diff/1/4
File generate_delta_main.cc (right):

http://codereview.chromium.org/4042004/diff/1/4#newcode91
generate_delta_main.cc:91: root_info.hash().end());
On 2010/10/22 20:15:16, petkov wrote:
> indent is off.
> 

Done.

http://codereview.chromium.org/4042004/diff/1/5
File omaha_hash_calculator.cc (right):

http://codereview.chromium.org/4042004/diff/1/5#newcode105
omaha_hash_calculator.cc:105: return
OmahaHashCalculator::Base64Encode(&raw_hash_[0],
On 2010/10/22 20:15:16, petkov wrote:
> You don't need OmahaHashCalculator:: I think.
> 

Done.

Expand Messages | Collapse Messages