Issue 4042: Add missing files to project to get test-shell fully linking. Fixes gcc warni...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4042: Add missing files to project to get test-shell fully linking. Fixes gcc warni... (Closed)

Created:
12 years, 3 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Amanda Walker, jar (doing other things)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add missing files to project to get test-shell fully linking. Fixes gcc warning/error in sdch_manager with members being initialized out of order. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2502

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -3 lines)			Patch
	M	net/base/sdch_manager.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	net/net.xcodeproj/project.pbxproj	View		7 chunks	+28 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

pink (ping after 24hrs)

jar, i wasn't sure if this was the *best* fix for the multiple members with ...

12 years, 3 months ago (2008-09-23 16:26:45 UTC) #1

jar (doing other things)

Changing the order of initializers LGTM. Thanks!!

12 years, 3 months ago (2008-09-23 16:38:07 UTC) #2

LGTM