Issue 404036: No need to run out of memory test under valgrind - they will obviously leak,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 404036: No need to run out of memory test under valgrind - they will obviously leak,... (Closed)

Created:
11 years, 1 month ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, brettw+cc_chromium.org, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

No need to run out of memory test under valgrind - they will obviously leak, but we don't care. BUG=28179 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32437

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	base/data/valgrind/base_unittests.gtest.txt	View		1 chunk	+4 lines, -0 lines	1 comment	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

11 years, 1 month ago (2009-11-18 23:47:44 UTC) #2

LGTM

http://codereview.chromium.org/404036/diff/1/3
File base/data/valgrind/base_unittests.gtest.txt (right):

http://codereview.chromium.org/404036/diff/1/3#newcode18
Line 18: # anything else, so just disable them on valgrind.
Can you add a note indicating this is bug 28179?

Expand Messages | Collapse Messages