Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 40317: Added unique id to all scripts (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Whenever a script object is created it is assigned a unique id. Currently this id is assigned from an 32 bit integer counter. Changed the script break points to be able to handle both break points based on script names and script ids. When break points are set through a script id the position is relative to the script itself. This is different from the script break points set through script names where the line/coulmn offset is taken into account. This has the side effect that function break points are not converted into script break points for named scripts. Show the script id in the D8 shell debugger when listing all scripts using the 'scripts' command. Committed: http://code.google.com/p/v8/source/detail?r=1468

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -114 lines) Patch
M include/v8.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/accessors.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/accessors.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/d8.js View 2 chunks +14 lines, -7 lines 0 comments Download
M src/debug-delay.js View 1 16 chunks +92 lines, -38 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/mirror-delay.js View 2 chunks +7 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 21 chunks +160 lines, -40 lines 0 comments Download
M test/mjsunit/debug-script-breakpoints.js View 4 chunks +48 lines, -7 lines 0 comments Download
M test/mjsunit/debug-setbreakpoint.js View 4 chunks +50 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
For the debugger in the Chrome developer tools the concept of a script id will ...
11 years, 9 months ago (2009-03-09 21:06:19 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/40317/diff/1/14 File src/debug-delay.js (right): http://codereview.chromium.org/40317/diff/1/14#newcode1019 Line 1019: }; Is indentation off by one here?
11 years, 9 months ago (2009-03-10 07:53:14 UTC) #2
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-10 08:09:41 UTC) #3
http://codereview.chromium.org/40317/diff/1/14
File src/debug-delay.js (right):

http://codereview.chromium.org/40317/diff/1/14#newcode1019
Line 1019: };
On 2009/03/10 07:53:14, Mads Ager wrote:
> Is indentation off by one here?

Done.

Powered by Google App Engine
This is Rietveld 408576698