Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4147)

Unified Diff: base/timer_unittest.cc

Issue 40312: Disable flaky TimerTest.DelayTimer_Reset test. (Closed)
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/timer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/timer_unittest.cc
diff --git a/base/timer_unittest.cc b/base/timer_unittest.cc
index 665a0666ffb8d4bb8c2231581a1c5b3c2eabe9af..74c6a6630742891fd9979faab9c3c8fe4db2dfab 100644
--- a/base/timer_unittest.cc
+++ b/base/timer_unittest.cc
@@ -318,7 +318,9 @@ TEST(TimerTest, DelayTimer_OneCall) {
RunTest_DelayTimer_OneCall(MessageLoop::TYPE_IO);
}
-TEST(TimerTest, DelayTimer_Reset) {
+// Disabled because it's flaky on the buildbot. Bug not filed because this
+// kind of test is difficult to make not-flaky on buildbots.
+TEST(TimerTest, DISABLED_DelayTimer_Reset) {
RunTest_DelayTimer_Reset(MessageLoop::TYPE_DEFAULT);
RunTest_DelayTimer_Reset(MessageLoop::TYPE_UI);
RunTest_DelayTimer_Reset(MessageLoop::TYPE_IO);
« no previous file with comments | « base/timer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698