Chromium Code Reviews| Index: master.cfg |
| =================================================================== |
| --- master.cfg (revision 11228) |
| +++ master.cfg (working copy) |
| @@ -288,14 +288,14 @@ |
| # URLs where the testers can find their build. |
| # NOTE: If you move a builder to another machine, you need to change these urls. |
| # TODO(nsylvain): Find a better way to express this. |
| -def __GetArchiveUrl(machine_name, builder_name): |
| +def _GetArchiveUrl(machine_name, builder_name): |
|
M-A Ruel
2009/03/09 18:50:07
not worth, it was already style compliant. :)
|
| return ('http://%s.jail.google.com/b/slave/%s/chrome_staging/' |
| 'full-build-win32.zip' % (machine_name, builder_name)) |
| -chromium_rel_archive = __GetArchiveUrl('codf32', 'chromium-rel-builder') |
| -chromium_dbg_archive = __GetArchiveUrl('codf31', 'chromium-dbg-builder') |
| -webkit_rel_archive = __GetArchiveUrl('hae184', 'webkit-rel-builder') |
| -webkit_dbg_archive = __GetArchiveUrl('hae183', 'webkit-dbg-builder') |
| +chromium_rel_archive = _GetArchiveUrl('codf32', 'chromium-rel-builder') |
| +chromium_dbg_archive = _GetArchiveUrl('codf31', 'chromium-dbg-builder') |
| +webkit_rel_archive = _GetArchiveUrl('hae184', 'webkit-rel-builder') |
| +webkit_dbg_archive = _GetArchiveUrl('hae183', 'webkit-dbg-builder') |
| # The identifier of the factory is the build configuration. If two factories |
| # are using the same build configuration, they should have the same identifier. |
| @@ -371,11 +371,11 @@ |
| 'printing']) |
| f_chromium_dbg_interactive_tests = m.NewBuildFactory(identifier='chromium-dbg', |
|
M-A Ruel
2009/03/09 18:50:07
pfff
you must align all the parameters to +4
Nicolas Sylvain
2009/03/09 18:56:17
the rule #1 in the python style guide is "be consi
|
| - target='Debug', |
| - slave_type='Tester', |
| - build_url=chromium_dbg_archive, |
| - run_crash_handler=True, |
| - tests=['interactive_ui']) |
| + target='Debug', |
| + slave_type='Tester', |
| + build_url=chromium_dbg_archive, |
| + run_crash_handler=True, |
| + tests=['interactive_ui']) |
| f_chromium_dbg_perf = m.NewBuildFactory(identifier='chromium-dbg', |
| target='Debug', |