Issue 4030005: Mac: Fix flicker on gpu->nongpu transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4030005: Mac: Fix flicker on gpu->nongpu transitions. (Closed)

Created:
10 years, 2 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit), stuartmorgan

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mac: Fix flicker on gpu->nongpu transitions. nongpu->gpu transitions still do flicker. BUG=57645 TEST=Go to http://nettuts.s3.amazonaws.com/771_sticky/step5.html , mouse-over a sticky note. Flickers less.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/render_widget_host.cc	View	1 2	3 chunks	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

Could this be handled internally to RWHVM, and the changes done when it gets the ...

10 years, 2 months ago (2010-10-25 17:28:19 UTC) #2

Nico

10 years, 1 month ago (2010-10-26 16:42:43 UTC) #4

On Mon, Oct 25, 2010 at 10:28 AM,  <stuartmorgan@chromium.org> wrote:
> Could this be handled internally to RWHVM, and the changes done when it gets
> the
> drawRect:? Seems like that would be cleaner, since it keeps the details of
> view
> management in the view class.

Yes, that seems cleaner. I will prepare a new CL.

>
>
> http://codereview.chromium.org/4030005/diff/2001/3001
> File chrome/browser/renderer_host/render_widget_host.cc (right):
>
> http://codereview.chromium.org/4030005/diff/2001/3001#newcode826
> chrome/browser/renderer_host/render_widget_host.cc:826: if
> (needs_to_hide_gpu_view_on_paint_) {
> This isn't going to compile on other platforms.
>
> http://codereview.chromium.org/4030005/show
>

Expand Messages | Collapse Messages