Chromium Code Reviews

Issue 40294: Work around issue 260 for now by disabling duplication of the loop... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Work around issue 260 for now by disabling duplication of the loop condition for while and for loops. http://code.google.com/p/v8/issues/detail?id=260 Committed: http://code.google.com/p/v8/source/detail?r=1453

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+141 lines, -57 lines)
M src/codegen-ia32.cc View 11 chunks +108 lines, -57 lines 0 comments
A test/mjsunit/regress/regress-260.js View 1 chunk +33 lines, -0 lines 0 comments

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
There is no need to port this to ARM because it still has the test ...
11 years, 9 months ago (2009-03-09 13:56:26 UTC) #1
Kasper Lund
11 years, 9 months ago (2009-03-09 13:59:45 UTC) #2
LGTM, but I think we should assertion code that explicitly checks that we don't
recompile function literals. Ever.

Powered by Google App Engine