Issue 40294: Work around issue 260 for now by disabling duplication of the loop...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40294: Work around issue 260 for now by disabling duplication of the loop... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Work around issue 260 for now by disabling duplication of the loop condition for while and for loops. http://code.google.com/p/v8/issues/detail?id=260 Committed: http://code.google.com/p/v8/source/detail?r=1453

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -57 lines)			Patch
	M	src/codegen-ia32.cc	View		11 chunks	+108 lines, -57 lines	0 comments	Download
	A	test/mjsunit/regress/regress-260.js	View		1 chunk	+33 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Chromium)

There is no need to port this to ARM because it still has the test ...

11 years, 9 months ago (2009-03-09 13:56:26 UTC) #1

Kasper Lund

11 years, 9 months ago (2009-03-09 13:59:45 UTC) #2

LGTM, but I think we should assertion code that explicitly checks that we don't
recompile function literals. Ever.