Issue 4027001: kernel_fetcher.sh: use ro for rootfs.image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4027001: kernel_fetcher.sh: use ro for rootfs.image (Closed)

Created:
10 years, 2 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
robotboy

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

kernel_fetcher.sh: use ro for rootfs.image With new changes to the rootfs, if it is verified, it won't be mountable rw. Since this script just copies out a file, making it ro (instead of calling enable_rw_mount) seems to make sense. TEST=? BUG=chromium-os:7468 Change-Id: I0941e981826005cea1c70653c45c5ae2c5f5a9e0

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	kernel_fetcher.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, I'm not sure this is even being used anymore.

Expand Messages | Collapse Messages