Issue 40255: Add API functions to control Quantify, as well as expose these...

Issue 40255: Add API functions to control Quantify, as well as expose these... (Closed)

Created:
11 years, 9 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add API functions to control Quantify, as well as expose these functions to javascript. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11291

Patch Set 3 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -0 lines)			Patch
M	base/base.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/base.scons	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/build/base.vcproj	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
A	base/profiler.h	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	base/profiler.cc	View		1 chunk	+45 lines, -0 lines	0 comments	Download
M	webkit/build/V8Bindings/SConscript	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/build/V8Bindings/V8Bindings.vcproj	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
A	webkit/extensions/v8/profiler_extension.h	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	webkit/extensions/v8/profiler_extension.cc	View	1 2	1 chunk	+89 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_main.cc	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/webkit.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

lgtm http://codereview.chromium.org/40255/diff/1014/22 File webkit/extensions/v8/profiler_extension.cc (right): http://codereview.chromium.org/40255/diff/1014/22#newcode12 Line 12: const char* kMDExtensionName = "v8/Profiler"; I suspect ...

11 years, 9 months ago (2009-03-09 15:45:02 UTC) #2

asargent_no_longer_on_chrome

11 years, 9 months ago (2009-03-09 21:26:06 UTC) #3

http://codereview.chromium.org/40255/diff/1014/22
File webkit/extensions/v8/profiler_extension.cc (right):

http://codereview.chromium.org/40255/diff/1014/22#newcode12
Line 12: const char* kMDExtensionName = "v8/Profiler";
On 2009/03/09 15:45:02, Mike Belshe wrote:
> I suspect "kMDExtensionName" should be "kProfilerExtensionName"?

Done.

http://codereview.chromium.org/40255/diff/1014/22#newcode57
Line 57: return v8::Number::New(0);
On 2009/03/09 15:45:02, Mike Belshe wrote:
> return v8Undefined() (also on lines 63 and 69 and 80)
> 

Done.

http://codereview.chromium.org/40255/diff/1014/26
File webkit/tools/test_shell/test_shell_switches.cc (right):

http://codereview.chromium.org/40255/diff/1014/26#newcode75
Line 75: extern const wchar_t kExposeProfilerToJs[] = L"expose-profiler-to-js";
On 2009/03/09 15:45:02, Mike Belshe wrote:
> could this be "--prof" instead of "--expose-profiler-to-js"?

Done.

Expand Messages | Collapse Messages